[PATCH 0/2] Enhancements to notmuch-hello search history
On Sun, 05 May 2013, Tomi Ollila wrote: > I agree with Jani that y-or-n-p would suffice for clearing all > recent searches (but yes-or-no-p is not so bad as I originally thought > as C-g can be used to stop processing (typoing 'no' is too easy ;/). > > If we could use "undo" feature to restore last clear/del then I'd agree > 100% with Mark (i.e. no y-or-n-p for [del]). > > In any case fix at least the style issue Mark mentioned -- any of the > yes/no queries will eventually be fine with me (as I don't know without > experience what would be the best (for me) after all). Servilio, please switch to y-or-n-p in patch 1 and fix the style issue in patch 2, and I think we're happy on the average. :) Jani.
[PATCH 0/2] Enhancements to notmuch-hello search history
On Sat, May 04 2013, Servilio Afre Puentes wrote: > Jani Nikula writes: > >> On Fri, 03 May 2013, Servilio Afre Puentes wrote: >>> Two patches that enhance the notmuch-hello search history UI. Though >>> minor I find them very helpful. >> >> Both seem to work as advertised; I did not look at the code much. A >> minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. > > I know, but as it clears the whole history I decided to go with a > confirmation that required more attention to diminish the chance of > accident, and the action is taken not so oftenly (at least for me, and > my guess is that it is the same for most) so it stills balances out > positively in the usability. I tested the patch and it works as advertised. I agree with Jani that y-or-n-p would suffice for clearing all recent searches (but yes-or-no-p is not so bad as I originally thought as C-g can be used to stop processing (typoing 'no' is too easy ;/). If we could use "undo" feature to restore last clear/del then I'd agree 100% with Mark (i.e. no y-or-n-p for [del]). In any case fix at least the style issue Mark mentioned -- any of the yes/no queries will eventually be fine with me (as I don't know without experience what would be the best (for me) after all). > Servilio Tomi
Re: [PATCH 0/2] Enhancements to notmuch-hello search history
On Sat, May 04 2013, Servilio Afre Puentes servi...@gmail.com wrote: Jani Nikula j...@nikula.org writes: On Fri, 03 May 2013, Servilio Afre Puentes servi...@gmail.com wrote: Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Both seem to work as advertised; I did not look at the code much. A minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. I know, but as it clears the whole history I decided to go with a confirmation that required more attention to diminish the chance of accident, and the action is taken not so oftenly (at least for me, and my guess is that it is the same for most) so it stills balances out positively in the usability. I tested the patch and it works as advertised. I agree with Jani that y-or-n-p would suffice for clearing all recent searches (but yes-or-no-p is not so bad as I originally thought as C-g can be used to stop processing (typoing 'no' is too easy ;/). If we could use undo feature to restore last clear/del then I'd agree 100% with Mark (i.e. no y-or-n-p for [del]). In any case fix at least the style issue Mark mentioned -- any of the yes/no queries will eventually be fine with me (as I don't know without experience what would be the best (for me) after all). Servilio Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Enhancements to notmuch-hello search history
On Sun, 05 May 2013, Tomi Ollila tomi.oll...@iki.fi wrote: I agree with Jani that y-or-n-p would suffice for clearing all recent searches (but yes-or-no-p is not so bad as I originally thought as C-g can be used to stop processing (typoing 'no' is too easy ;/). If we could use undo feature to restore last clear/del then I'd agree 100% with Mark (i.e. no y-or-n-p for [del]). In any case fix at least the style issue Mark mentioned -- any of the yes/no queries will eventually be fine with me (as I don't know without experience what would be the best (for me) after all). Servilio, please switch to y-or-n-p in patch 1 and fix the style issue in patch 2, and I think we're happy on the average. :) Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/2] Enhancements to notmuch-hello search history
Jani Nikula writes: > On Fri, 03 May 2013, Servilio Afre Puentes wrote: >> Two patches that enhance the notmuch-hello search history UI. Though >> minor I find them very helpful. > > Both seem to work as advertised; I did not look at the code much. A > minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. I know, but as it clears the whole history I decided to go with a confirmation that required more attention to diminish the chance of accident, and the action is taken not so oftenly (at least for me, and my guess is that it is the same for most) so it stills balances out positively in the usability. Servilio
[PATCH 0/2] Enhancements to notmuch-hello search history
On Fri, 03 May 2013, Servilio Afre Puentes wrote: > Two patches that enhance the notmuch-hello search history UI. Though > minor I find them very helpful. Both seem to work as advertised; I did not look at the code much. A minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. BR, Jani.
Re: [PATCH 0/2] Enhancements to notmuch-hello search history
On Fri, 03 May 2013, Servilio Afre Puentes servi...@gmail.com wrote: Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Both seem to work as advertised; I did not look at the code much. A minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. BR, Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Enhancements to notmuch-hello search history
Jani Nikula j...@nikula.org writes: On Fri, 03 May 2013, Servilio Afre Puentes servi...@gmail.com wrote: Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Both seem to work as advertised; I did not look at the code much. A minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. I know, but as it clears the whole history I decided to go with a confirmation that required more attention to diminish the chance of accident, and the action is taken not so oftenly (at least for me, and my guess is that it is the same for most) so it stills balances out positively in the usability. Servilio ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/2] Enhancements to notmuch-hello search history
Hi, Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Servilio Afre Puentes (2): emacs: hello: ask confirmation for clearing recent searches emacs: hello: allow deleting individual searches in the history emacs/notmuch-hello.el | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) -- 1.8.2.1
[PATCH 0/2] Enhancements to notmuch-hello search history
Hi, Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Servilio Afre Puentes (2): emacs: hello: ask confirmation for clearing recent searches emacs: hello: allow deleting individual searches in the history emacs/notmuch-hello.el | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) -- 1.8.2.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
