[PATCH 1/1] release-checks: removed manual page version check
Tomi Ollila writes: > Manual pages are now generated and during the generation the version > string is read from `version` file, so this (currently failing) test > checking manual page versions can be removed. > pushed, d
Re: [PATCH 1/1] release-checks: removed manual page version check
Tomi Ollila tomi.oll...@iki.fi writes: Manual pages are now generated and during the generation the version string is read from `version` file, so this (currently failing) test checking manual page versions can be removed. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 1/1] release-checks: removed manual page version check
Manual pages are now generated and during the generation the version
string is read from `version` file, so this (currently failing) test
checking manual page versions can be removed.
While at it, changed the case pattern *[^0-9.]*
to its portable alternative *[!0-9.]*
---
devel/release-checks.sh | 42 +-
1 file changed, 1 insertion(+), 41 deletions(-)
diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index 8938905..797d62a 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -68,7 +68,7 @@ verfail ()
echo -n "Checking that '$VERSION' is good with digits and periods... "
case $VERSION in
- *[^0-9.]*)
+ *[!0-9.]*)
verfail "'$VERSION' contains other characters than digits and
periods" ;;
.*) verfail "'$VERSION' begins with a period" ;;
*.) verfail "'$VERSION' ends with a period" ;;
@@ -196,46 +196,6 @@ case $news_date in
append_emsg "Date '$news_date' in NEWS file is not in format
(-mm-dd)"
esac
-readonly DATE=${news_date//[()]/} # bash feature
-manthdata ()
-{
- set x $*
- if [ $# != 7 ]
- then
- append_emsg "'$mp' has too many '.TH' lines"
- man_mismatch=1
- fi
- man_date=${5-} man_version=${7-}
-}
-
-echo -n "Checking that manual page dates and versions are $DATE and
$VERSION... "
-manfiles=`find man -type f | sort`
-man_pages_ok=Yes
-for mp in $manfiles
-do
- case $mp in
- *.[0-9]) ;; # fall below this 'case ... esac'
-
- */Makefile.local | */Makefile ) continue ;;
- */.gitignore) continue ;;
- *.bak) continue ;;
-
- *) append_emsg "'$mp': extra file"
- man_pages_ok=No
- continue
- esac
- manthdata `sed -n '/^[.]TH NOTMUCH/ { y/"/ /; p; }' "$mp"`
- if [ "$man_version" != "$VERSION" ]
- thenappend_emsg "Version '$man_version' is not '$VERSION' in $mp"
- mman_pages_ok=No
- fi
- if [ "$man_date" != "$DATE" ]
- thenappend_emsg "DATE '$man_date' is not '$DATE' in $mp"
- man_pages_ok=No
- fi
-done
-echo $man_pages_ok.
-
if [ -n "$emsgs" ]
then
echo
--
1.8.0
[PATCH 1/1] release-checks: removed manual page version check
Manual pages are now generated and during the generation the version
string is read from `version` file, so this (currently failing) test
checking manual page versions can be removed.
While at it, changed the case pattern *[^0-9.]*
to its portable alternative *[!0-9.]*
---
devel/release-checks.sh | 42 +-
1 file changed, 1 insertion(+), 41 deletions(-)
diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index 8938905..797d62a 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -68,7 +68,7 @@ verfail ()
echo -n Checking that '$VERSION' is good with digits and periods...
case $VERSION in
- *[^0-9.]*)
+ *[!0-9.]*)
verfail '$VERSION' contains other characters than digits and
periods ;;
.*) verfail '$VERSION' begins with a period ;;
*.) verfail '$VERSION' ends with a period ;;
@@ -196,46 +196,6 @@ case $news_date in
append_emsg Date '$news_date' in NEWS file is not in format
(-mm-dd)
esac
-readonly DATE=${news_date//[()]/} # bash feature
-manthdata ()
-{
- set x $*
- if [ $# != 7 ]
- then
- append_emsg '$mp' has too many '.TH' lines
- man_mismatch=1
- fi
- man_date=${5-} man_version=${7-}
-}
-
-echo -n Checking that manual page dates and versions are $DATE and
$VERSION...
-manfiles=`find man -type f | sort`
-man_pages_ok=Yes
-for mp in $manfiles
-do
- case $mp in
- *.[0-9]) ;; # fall below this 'case ... esac'
-
- */Makefile.local | */Makefile ) continue ;;
- */.gitignore) continue ;;
- *.bak) continue ;;
-
- *) append_emsg '$mp': extra file
- man_pages_ok=No
- continue
- esac
- manthdata `sed -n '/^[.]TH NOTMUCH/ { y// /; p; }' $mp`
- if [ $man_version != $VERSION ]
- thenappend_emsg Version '$man_version' is not '$VERSION' in $mp
- mman_pages_ok=No
- fi
- if [ $man_date != $DATE ]
- thenappend_emsg DATE '$man_date' is not '$DATE' in $mp
- man_pages_ok=No
- fi
-done
-echo $man_pages_ok.
-
if [ -n $emsgs ]
then
echo
--
1.8.0
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
