Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-17 Thread Tomi Ollila
On Tue, Jul 14 2020, Floris Bruynooghe wrote: > On Sat 11 Jul 2020 at 10:20 -0300, David Bremner wrote: > >> I don't love the use of exec, but it is getting unwieldy to pass > > It's already a config file written in Python which is a terrible sin. > So no need to apologise, I think it makes sense

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-15 Thread David Bremner
Tomi Ollila writes: > > perhaps instead of multiple redirections to the file, > > { > echo "# Generated by configure, run from doc/conf.py" > echo > if [ $WITH_EMACS = "1" ]; then > printf "tags.add('WITH_EMACS')\n" > fi > printf "rsti_dir = '%s'\n" "$(realpath

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-14 Thread Floris Bruynooghe
On Sat 11 Jul 2020 at 17:00 +0300, Tomi Ollila wrote: > On Sat, Jul 11 2020, David Bremner wrote: > >> I don't love the use of exec, but it is getting unwieldy to pass >> configuration options on the sphinx-build command line, and I >> anticipate further use of conditionals. > > Perhaps less

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-14 Thread Floris Bruynooghe
On Sat 11 Jul 2020 at 10:20 -0300, David Bremner wrote: > I don't love the use of exec, but it is getting unwieldy to pass It's already a config file written in Python which is a terrible sin. So no need to apologise, I think it makes sense in this context. > configuration options on the

Re: [PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-11 Thread Tomi Ollila
On Sat, Jul 11 2020, David Bremner wrote: > I don't love the use of exec, but it is getting unwieldy to pass > configuration options on the sphinx-build command line, and I > anticipate further use of conditionals. Perhaps less "opinions" in commit message. (and as I think I don't comment 2/2,

[PATCH 1/2] doc: replace use of environment variables with a generated config

2020-07-11 Thread David Bremner
I don't love the use of exec, but it is getting unwieldy to pass configuration options on the sphinx-build command line, and I anticipate further use of conditionals. --- configure | 8 doc/Makefile.local | 2 +- doc/conf.py| 11 --- 3 files changed, 17