[PATCH 1/3] Add notmuch_database_close_compact

2012-10-18 Thread Tomi Ollila
On Wed, Oct 17 2012, Ben Gamari wrote: > --- > configure | 21 - > lib/database.cc | 54 ++ > lib/notmuch.h | 14 ++ > 3 files changed, 88 insertions(+), 1 deletion(-) > > diff --git a/configure

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-10-18 Thread Tomi Ollila
On Wed, Oct 17 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- configure | 21 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 88 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] Add notmuch_database_close_compact

2012-10-17 Thread Jani Nikula
Hi Ben - I'd like some meaningful commit messages here. Please find other comments inline. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari wrote: > --- > configure | 21 - > lib/database.cc | 54 ++ > lib/notmuch.h

[PATCH 1/3] Add notmuch_database_close_compact

2012-10-17 Thread Ben Gamari
--- configure | 21 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 88 insertions(+), 1 deletion(-) diff --git a/configure b/configure index acb90a8..6551b13 100755 ---

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-10-17 Thread Jani Nikula
Hi Ben - I'd like some meaningful commit messages here. Please find other comments inline. BR, Jani. On Wed, 17 Oct 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- configure | 21 - lib/database.cc | 54 ++

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-23 Thread Tomi Ollila
On Thu, Aug 23 2012, Kim Minh Kaplan wrote: > Tomi Ollila?: > >> On Tue, Aug 21 2012, Ben Gamari wrote: >> >>> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the >>> public API. >> >> Presuming that those variables are always numeric the

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-23 Thread Kim Minh Kaplan
Tomi Ollila?: > On Tue, Aug 21 2012, Ben Gamari wrote: > >> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the >> public API. > > Presuming that those variables are always numeric the comparison could be: > > if [ ${xapian_major_version} -gt 1 ] || >[

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-08-23 Thread Tomi Ollila
On Thu, Aug 23 2012, Kim Minh Kaplan kimminh.kaplan+nom...@afnic.fr wrote: Tomi Ollila : On Tue, Aug 21 2012, Ben Gamari wrote: Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the public API. Presuming that those variables are always numeric the comparison could be:

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-22 Thread Tomi Ollila
On Tue, Aug 21 2012, Ben Gamari wrote: > Tomi Ollila writes: > >> On Mon, Aug 20 2012, Ben Gamari wrote: >> > >> Hmm, I guess the check above is to determine whether xapian version is >> 1.2.6 or newer, but is there xapian version 1.1.6 or 1.0.6 or 0.3.0 or so ? >> > Eh? 1.2.6 is the first

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-08-22 Thread Tomi Ollila
On Tue, Aug 21 2012, Ben Gamari wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Mon, Aug 20 2012, Ben Gamari bgamari.f...@gmail.com wrote: Hmm, I guess the check above is to determine whether xapian version is 1.2.6 or newer, but is there xapian version 1.1.6 or 1.0.6 or 0.3.0 or so ?

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-08-22 Thread Kim Minh Kaplan
Tomi Ollila : On Tue, Aug 21 2012, Ben Gamari wrote: Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the public API. Presuming that those variables are always numeric the comparison could be: if [ ${xapian_major_version} -gt 1 ] || [ ${xapian_major_version} -eq 1

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-21 Thread Ben Gamari
Tomi Ollila writes: > On Mon, Aug 20 2012, Ben Gamari wrote: > >> --- >> configure | 25 - >> lib/database.cc | 54 >> ++ >> lib/notmuch.h | 14 ++ >> 3 files changed, 92 insertions(+), 1

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-21 Thread Tomi Ollila
On Mon, Aug 20 2012, Ben Gamari wrote: > --- > configure | 25 - > lib/database.cc | 54 ++ > lib/notmuch.h | 14 ++ > 3 files changed, 92 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/3] Add notmuch_database_close_compact

2012-08-21 Thread Tomi Ollila
On Mon, Aug 20 2012, Ben Gamari bgamari.f...@gmail.com wrote: --- configure | 25 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 92 insertions(+), 1 deletion(-) diff

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-20 Thread Ben Gamari
--- configure | 25 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/configure b/configure index dc0dba4..370fedd 100755 ---

[PATCH 1/3] Add notmuch_database_close_compact

2012-08-20 Thread Ben Gamari
--- configure | 25 - lib/database.cc | 54 ++ lib/notmuch.h | 14 ++ 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/configure b/configure index dc0dba4..370fedd 100755 ---