Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:38:29 -0700, Carl Worth wrote: > commit d5b4d950245605b84c56ce991fa3c59a073a70e5 > Author: Jameson Graef Rollins > Date: Sat May 28 14:52:00 2011 -0700 > > show: Avoid inadvertently closing stdout > > GMime has a nasty habit of taking ownership by default of

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 15:38:29 -0700, Carl Worth wrote: > commit d5b4d950245605b84c56ce991fa3c59a073a70e5 > Author: Jameson Graef Rollins > Date: Sat May 28 14:52:00 2011 -0700 > > show: Avoid inadvertently closing stdout > > GMime has a nasty habit of taking ownership by default of

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Carl Worth
On Fri, 03 Jun 2011 14:26:48 -0700, Jameson Graef Rollins wrote: > Well actually it's only meant to sound like the committer doesn't > understand the problem! Heh, OK. > > I'd like to investigate this more. Perhaps with a test case? > > The current tests are how I found the problem! Without t

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Carl Worth
On Fri, 03 Jun 2011 14:26:48 -0700, Jameson Graef Rollins wrote: > Well actually it's only meant to sound like the committer doesn't > understand the problem! Heh, OK. > > I'd like to investigate this more. Perhaps with a test case? > > The current tests are how I found the problem! Without th

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > Otherwise, the patches up to this point in the thread have all either > been pushed or I've asked for some additional information (perhaps > that's just this patch and the "old style fcc dirs" patch?). Great! That's really great news, Carl.

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > Otherwise, the patches up to this point in the thread have all either > been pushed or I've asked for some additional information (perhaps > that's just this patch and the "old style fcc dirs" patch?). Great! That's really great news, Carl.

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins > wrote: > > The declaration of the GMimeStream pointer to stdout in > > format_part_content_text was somehow preventing subsequent printf > > calls from outputting to stdout if the

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Jameson Graef Rollins
On Fri, 03 Jun 2011 12:56:50 -0700, Carl Worth wrote: > On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins finestructure.net> wrote: > > The declaration of the GMimeStream pointer to stdout in > > format_part_content_text was somehow preventing subsequent printf > > calls from outputting t

Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Carl Worth
On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins wrote: > The declaration of the GMimeStream pointer to stdout in > format_part_content_text was somehow preventing subsequent printf > calls from outputting to stdout if the output was redirected to a > file. Scoping the declaration to th

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-06-03 Thread Carl Worth
On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins wrote: > The declaration of the GMimeStream pointer to stdout in > format_part_content_text was somehow preventing subsequent printf > calls from outputting to stdout if the output was redirected to a > file. Scoping the declaration to the

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-05-28 Thread Jameson Graef Rollins
The declaration of the GMimeStream pointer to stdout in format_part_content_text was somehow preventing subsequent printf calls from outputting to stdout if the output was redirected to a file. Scoping the declaration to the actual use of the stream pointer works around this problem. --- notmuch-

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-05-28 Thread Jameson Graef Rollins
The declaration of the GMimeStream pointer to stdout in format_part_content_text was somehow preventing subsequent printf calls from outputting to stdout if the output was redirected to a file. Scoping the declaration to the actual use of the stream pointer works around this problem. --- notmuch-