Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-08-06 Thread Daniel Kahn Gillmor
Hi Bremner-- thanks for the review! On Sat 2019-08-03 12:15:30 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> +ret = true; >> +for (int i = 0; i < g_mime_header_list_get_count >> (legacy_display_headers); i++) { >> +GMimeHeader *dh =

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-08-03 Thread David Bremner
Daniel Kahn Gillmor writes: > + ret = true; > + for (int i = 0; i < g_mime_header_list_get_count > (legacy_display_headers); i++) { > + GMimeHeader *dh = g_mime_header_list_get_header_at > (legacy_display_headers, i); > + if (dh == NULL) { > + ret = false; >

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-25 Thread Daniel Kahn Gillmor
On Mon 2019-06-24 20:02:13 -0700, William Casarin wrote: > dkg wrote: >> +if ((protected_headers = g_mime_object_get_header_list (payload), >> protected_headers) && >> +(legacy_display = GMIME_TEXT_PART (first), legacy_display) && >> +(legacy_display_header_text =

Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-24 Thread William Casarin
Daniel Kahn Gillmor writes: > This is a utility function designed to make it easier to > "fast-forward" past a legacy-display part associated with a > cryptographic envelope, and show the user the intended message body. > > The bulk of the ugliness in here is in the test function >

[PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

2019-06-24 Thread Daniel Kahn Gillmor
This is a utility function designed to make it easier to "fast-forward" past a legacy-display part associated with a cryptographic envelope, and show the user the intended message body. The bulk of the ugliness in here is in the test function _notmuch_crypto_payload_has_legacy_display, which