Re: [PATCH 9/9] emacs/reply: reply to correct duplicate

2022-07-30 Thread David Bremner
David Bremner  writes:

> Essentially we just need to arrange to pass the right --duplicate
> argument to notmuch reply.
>
> As a side-effect, correct the previously unused value of EXPECTED in
> T453-emacs-reply.sh.

remainder of series applied to master.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


[PATCH 9/9] emacs/reply: reply to correct duplicate

2022-07-01 Thread David Bremner
Essentially we just need to arrange to pass the right --duplicate
argument to notmuch reply.

As a side-effect, correct the previously unused value of EXPECTED in
T453-emacs-reply.sh.
---
 emacs/notmuch-mua.el  | 18 +
 emacs/notmuch-show.el |  6 ++-
 test/T453-emacs-reply.sh  | 39 ++-
 .../notmuch-reply-duplicate-4 | 21 ++
 4 files changed, 73 insertions(+), 11 deletions(-)
 create mode 100644 test/emacs-reply.expected-output/notmuch-reply-duplicate-4

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 0f9ef3c2..ac878a61 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -237,11 +237,12 @@ Typically this is added to `notmuch-mua-send-hook'."
 
 ;;; Mua reply
 
-(defun notmuch-mua-reply (query-string  sender reply-all)
-  (let ((args '("reply" "--format=sexp" "--format-version=5"))
-   (process-crypto notmuch-show-process-crypto)
-   reply
-   original)
+(defun notmuch-mua-reply (query-string  sender reply-all duplicate)
+  (let* ((duparg (and duplicate (list (format "--duplicate=%d" duplicate
+(args `("reply" "--format=sexp" "--format-version=5" ,@duparg))
+(process-crypto notmuch-show-process-crypto)
+reply
+original)
 (when process-crypto
   (setq args (append args '("--decrypt=true"
 (if reply-all
@@ -540,12 +541,13 @@ the From: address."
   (message-hide-headers)
   (set-buffer-modified-p nil
 
-(defun notmuch-mua-new-reply (query-string  prompt-for-sender 
reply-all)
+(defun notmuch-mua-new-reply (query-string  prompt-for-sender 
reply-all duplicate)
   "Compose a reply to the message identified by QUERY-STRING.
 
 If PROMPT-FOR-SENDER is non-nil, the user will be prompted for
 the From: address first.  If REPLY-ALL is non-nil, the message
-will be addressed to all recipients of the source message."
+will be addressed to all recipients of the source message.  If
+DUPLICATE is non-nil, based the reply on that duplicate file"
   ;; `select-active-regions' is t by default. The reply insertion code
   ;; sets the region to the quoted message to make it easy to delete
   ;; (kill-region or C-w). These two things combine to put the quoted
@@ -560,7 +562,7 @@ will be addressed to all recipients of the source message."
   (let ((sender (and prompt-for-sender
 (notmuch-mua-prompt-for-sender)))
(select-active-regions nil))
-(notmuch-mua-reply query-string sender reply-all)
+(notmuch-mua-reply query-string sender reply-all duplicate)
 (deactivate-mark)))
 
 ;;; Checks
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ee01e470..cc34876b 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2020,13 +2020,15 @@ any effects from previous calls to
 (defun notmuch-show-reply ( prompt-for-sender)
   "Reply to the sender and all recipients of the current message."
   (interactive "P")
-  (notmuch-mua-new-reply (notmuch-show-get-message-id) prompt-for-sender t))
+  (notmuch-mua-new-reply (notmuch-show-get-message-id) prompt-for-sender t
+(notmuch-show-get-prop :duplicate)))
 
 (put 'notmuch-show-reply-sender 'notmuch-prefix-doc "... and prompt for 
sender")
 (defun notmuch-show-reply-sender ( prompt-for-sender)
   "Reply to the sender of the current message."
   (interactive "P")
-  (notmuch-mua-new-reply (notmuch-show-get-message-id) prompt-for-sender nil))
+  (notmuch-mua-new-reply (notmuch-show-get-message-id) prompt-for-sender nil
+(notmuch-show-get-prop :duplicate)))
 
 (put 'notmuch-show-forward-message 'notmuch-prefix-doc
  "... and prompt for sender")
diff --git a/test/T453-emacs-reply.sh b/test/T453-emacs-reply.sh
index c26c4473..0a27d066 100755
--- a/test/T453-emacs-reply.sh
+++ b/test/T453-emacs-reply.sh
@@ -4,7 +4,7 @@ test_description="emacs reply"
 . $(dirname "$0")/test-lib.sh || exit 1
 . $NOTMUCH_SRCDIR/test/test-lib-emacs.sh || exit 1
 
-EXPECTED=$NOTMUCH_SRCDIR/test/emacs-show.expected-output
+EXPECTED=$NOTMUCH_SRCDIR/test/emacs-reply.expected-output
 
 test_require_emacs
 
@@ -31,4 +31,41 @@ EOF
 notmuch_dir_sanitize < OUTPUT.raw > OUTPUT
 test_expect_equal_file EXPECTED OUTPUT
 
+add_email_corpus duplicate
+
+ID2=87r2geywh9@tethera.net
+for dup in {1..2}; do
+test_begin_subtest "body, duplicate=${dup}"
+test_emacs "(notmuch-show \"id:${ID2}\")
+  (notmuch-test-wait)
+  (notmuch-show-choose-duplicate $dup)
+  (notmuch-test-wait)
+  (notmuch-show-reply)
+  (test-visible-output \"OUTPUT.raw\")"
+output=$(grep '^> # body' OUTPUT.raw)
+test_expect_equal "$output" "> # body ${dup}"
+done
+
+ID3=87r2ecrr6x@zephyr.silentflame.com
+test_begin_subtest "duplicate=3, subject"
+test_emacs "(notmuch-show \"id:${ID3}\")
+  (notmuch-test-wait)
+  (notmuch-show-choose-duplicate 3)
+