Re: [PATCH v2 0/3] emacs: Document notmuch-show-get-message-properties

2011-12-16 Thread Jameson Graef Rollins
On Fri, 16 Dec 2011 09:01:21 -0400, David Bremner da...@tethera.net wrote: The others are (not too surprisingly) stale and need rebasing. I'm also not clear on whether we have concensus on whether the patches are suitable for inclusion, so feedback from others would be welcome (perhaps before

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-04 Thread Austin Clements
On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins finestructure.net> wrote: >> In order to push forward with this, though, I think we really need to >> have a complete unit test for this new functionality. ?We usually like >> to see

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-04 Thread Austin Clements
On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula j...@nikula.org wrote: On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: In order to push forward with this, though, I think we really need to have a complete unit test for this new functionality.  We

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-02 Thread Jani Nikula
On Tue, 01 Nov 2011 09:30:56 -0300, David Bremner wrote: > Is just because it add a function to the library that you think this > might be problematic? I don't think we are super-dogmatic about the > library never growing. When notmuch started, there were no bindings, so > in retrospect maybe

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-02 Thread Jani Nikula
On Tue, 01 Nov 2011 09:30:56 -0300, David Bremner da...@tethera.net wrote: Is just because it add a function to the library that you think this might be problematic? I don't think we are super-dogmatic about the library never growing. When notmuch started, there were no bindings, so in

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > > I'm still marking it as RFC. It works for me, but patch 1 might be deemed > unacceptable. > Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are super-dogmatic about

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread Jani Nikula
On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: > Hi, Jani. Thanks for working on this. This should also be valuable for > vim users. Thanks for your interest! :) > In order to push forward with this, though, I think we really need to > have a complete unit test for this new

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread Jani Nikula
Hi, this is an iteration of id:"cover.1319833617.git.jani at nikula.org" addressing comments on the list and IRC. Main changes: * Results are now limited based on threads (not messages) for thread and summary output. This is accomplished with a new lib function to count the number of threads

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula j...@nikula.org wrote: I'm still marking it as RFC. It works for me, but patch 1 might be deemed unacceptable. Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 00:07:59 +0200, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins finestructure.net> wrote: > Right. I'd just like to make sure the approach I've taken (particularly > patch 1 in the set as it touches the lib) is acceptable before spending > time

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > Hi, this is an iteration of id:"cover.1319833617.git.jani at nikula.org" > addressing > comments on the list and IRC. Main changes: > > * Results are now limited based on threads (not messages) for thread and > summary > output. This

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jani Nikula
Hi, this is an iteration of id:cover.1319833617.git.j...@nikula.org addressing comments on the list and IRC. Main changes: * Results are now limited based on threads (not messages) for thread and summary output. This is accomplished with a new lib function to count the number of threads in

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-10-31 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 00:07:59 +0200, Jani Nikula j...@nikula.org wrote: On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Right. I'd just like to make sure the approach I've taken (particularly patch 1 in the set as it touches the lib) is acceptable

[PATCH v2 0/3] improved broken tests support and test for a bug

2011-09-10 Thread David Bremner
On Mon, 4 Jul 2011 08:07:18 +0400, Dmitry Kurochkin wrote: > This version implements suggestions by Austin. > > Regards, > Dmitry I have pushed this series.

Re: [PATCH v2 0/3] improved broken tests support and test for a bug

2011-09-10 Thread David Bremner
On Mon, 4 Jul 2011 08:07:18 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: This version implements suggestions by Austin. Regards, Dmitry I have pushed this series. ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v2 0/3] emacs: Document notmuch-show-get-message-properties

2011-07-08 Thread Daniel Schoepe
This version fixes the issues mentioned by Austin and highlights the currently displayed message in the outline buffer. My previous issues with 'point-entered and 'point-left were caused by linum-mode, so don't enable it for notmuch-show buffers. I haven't had time yet to implement a more

[PATCH v2 0/3] emacs: Document notmuch-show-get-message-properties

2011-07-08 Thread Daniel Schoepe
This version fixes the issues mentioned by Austin and highlights the currently displayed message in the outline buffer. My previous issues with 'point-entered and 'point-left were caused by linum-mode, so don't enable it for notmuch-show buffers. I haven't had time yet to implement a more

[PATCH v2 0/3] improved broken tests support and test for a bug

2011-07-04 Thread Dmitry Kurochkin
This version implements suggestions by Austin. Regards, Dmitry

[PATCH v2 0/3] improved broken tests support and test for a bug

2011-07-03 Thread Dmitry Kurochkin
This version implements suggestions by Austin. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 0/3] Implement reply to sender

2011-05-27 Thread Mark Walters
Many thanks for the rapid response: I have modified the patches as suggested and this version includes the necessary documentation changes. I have also modified the emacs portion to apply to current master. Best wishes Mark These patches implement a reply to sender function. On the command

[PATCH v2 0/3] Implement reply to sender

2011-05-26 Thread Mark Walters
Many thanks for the rapid response: I have modified the patches as suggested and this version includes the necessary documentation changes. I have also modified the emacs portion to apply to current master. Best wishes Mark These patches implement a reply to sender function. On the command

<    1   2