On Sun, 22 Nov 2009 17:11:03 +0200, Dirk-Jan C. Binnema wrote:
>
> (hopefully this is the correct way to send patches...)
Looks just fine, and welcome to notmuch!
> With these minor changes, notmuch compiles warning-free with gcc 4.4.1
Could you resend these as separate patches, each patch fix
On Sun, Nov 22, 2009 at 9:22 PM, Carl Worth wrote:
> On Sun, 22 Nov 2009 17:11:03 +0200, Dirk-Jan C. Binnema gmail.com> wrote:
>>
>> - ? ?write(2, msg, sizeof(msg)-1);
>> + ? ?if (write(2, msg, sizeof(msg)-1) < 0) {
>> + ? ? ? ? /* ignore...*/
>> + ? ?}
>
> I don't like the gratuitous conditional
(hopefully this is the correct way to send patches...)
With these minor changes, notmuch compiles warning-free with gcc 4.4.1
---
notmuch-new.c |4 +++-
notmuch-setup.c | 13 +++--
notmuch-tag.c |4 +++-
3 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/notmu
