Re: [PATCH] emacs: add global tag history

2023-01-10 Thread inwit
On Fri Jan 6, 2023 at 12:36 PM CET, David Bremner wrote: > Although this patch won't apply anymore, thanks for inspiring the work that > lead to supporting undo. Unfortunately I stole the name > "notmuch-tag-history" for a buffer local variable, so I guess someone > interested in a global history

Re: [PATCH] emacs: add global tag history

2023-01-06 Thread David Bremner
inwit writes: > Save a list of every tag change in the new variable notmuch-tag-history. > --- > Storing the full history of tags can prove useful for a) repeated tag > changes as in [0] and b) eventually logging and undoing tag changes. > > This is my first commit in elisp. I expect turbulences

Re: [PATCH] emacs: add global tag history

2022-01-27 Thread David Bremner
inwit writes: > On 2022-01-26 16:40, David Bremner wrote: >> I guess for undo you will need to save the query as well? >> >> Even that will not be perfect (since the messages matching the query >> could change behind emacs back), but close enough for most interactive >> use, maybe? > > I was

Re: [PATCH] emacs: add global tag history

2022-01-27 Thread inwit
On Wed Jan 26, 2022 at 6:43 PM CET, Jose Antonio Ortega Ruiz wrote: > maybe this could be a buffer-local history variable, for notmuch search > and tree search buffers, and the undo feature apply only to the current > search buffer. the view update is then well-defined, i think, if it's > just

Re: [PATCH] emacs: add global tag history

2022-01-26 Thread David Bremner
David Bremner writes: > One thing that has changed since those early days is that we now have > lastmod (see notmuch-search-terms(7)): queries, but that is still not > atomic. I guess it might not be too hard to have notmuch tag output > output the correct lastmod value. Then we could store that

Re: [PATCH] emacs: add global tag history

2022-01-26 Thread David Bremner
Carl Worth writes: > On Wed, Jan 26 2022, inwit wrote: >>> Even that will not be perfect (since the messages matching the query >>> could change behind emacs back), but close enough for most interactive >>> use, maybe? >> >> I was thinking about saving the IDs of the messages affected by the >>

Re: [PATCH] emacs: add global tag history

2022-01-26 Thread Carl Worth
On Wed, Jan 26 2022, inwit wrote: >> Even that will not be perfect (since the messages matching the query >> could change behind emacs back), but close enough for most interactive >> use, maybe? > > I was thinking about saving the IDs of the messages affected by the > change, but I still don't

Re: [PATCH] emacs: add global tag history

2022-01-26 Thread inwit
On 2022-01-26 16:40, David Bremner wrote: I guess for undo you will need to save the query as well? Even that will not be perfect (since the messages matching the query could change behind emacs back), but close enough for most interactive use, maybe? I was thinking about saving the IDs of

Re: [PATCH] emacs: add global tag history

2022-01-26 Thread David Bremner
inwit writes: > Save a list of every tag change in the new variable notmuch-tag-history. > --- > Storing the full history of tags can prove useful for a) repeated tag > changes as in [0] and b) eventually logging and undoing tag changes. I guess for undo you will need to save the query as well?

[PATCH] emacs: add global tag history

2022-01-26 Thread inwit
Save a list of every tag change in the new variable notmuch-tag-history. --- Storing the full history of tags can prove useful for a) repeated tag changes as in [0] and b) eventually logging and undoing tag changes. This is my first commit in elisp. I expect turbulences ahead. :) [0]