Re: [PATCH v2 1/2] ruby: add keyword arguments to db.query

2021-06-28 Thread Felipe Contreras
On Sun, Jun 27, 2021 at 12:18 PM David Bremner wrote: > > Felipe Contreras writes: > > > That way we don't need pass them to the query object ourselves. > > I have applied this change to master. As we discussed previously, I > prefer to leave the sort order explicit in the tests. OK. I still

Re: [PATCH v2 1/2] ruby: add keyword arguments to db.query

2021-06-27 Thread David Bremner
Felipe Contreras writes: > That way we don't need pass them to the query object ourselves. > I have applied this change to master. As we discussed previously, I prefer to leave the sort order explicit in the tests. d ___ notmuch mailing list --

[PATCH v2 1/2] ruby: add keyword arguments to db.query

2021-05-23 Thread Felipe Contreras
That way we don't need pass them to the query object ourselves. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 47 +--- bindings/ruby/defs.h | 2 +- bindings/ruby/init.c | 2 +- test/T395-ruby.sh| 18 +++ 4 files