Concerns regarding some library functions

2011-10-04 Thread Tomi Ollila
On Tue 04 Oct 2011 14:18, David Bremner writes: > > So I've pushed the ABI changes, making it more urgent to do something > about this. At this point I'm inclined to bump the soname in order to > unbreak things, unless someone wants to come up with a convincing set of > patches to do the symbol

Concerns regarding some library functions

2011-10-04 Thread David Bremner
On Thu, 29 Sep 2011 16:15:36 -0400, Austin Clements wrote: > With symbol versioning we'd still provide the old function (presumably > re-implemented in terms of the new function). Both would wind up in > the .so and old binaries would still link against the old symbol. It > doesn't help that

Re: Concerns regarding some library functions

2011-10-04 Thread David Bremner
On Thu, 29 Sep 2011 16:15:36 -0400, Austin Clements amdra...@mit.edu wrote: With symbol versioning we'd still provide the old function (presumably re-implemented in terms of the new function). Both would wind up in the .so and old binaries would still link against the old symbol. It doesn't

Re: Concerns regarding some library functions

2011-10-04 Thread Tomi Ollila
On Tue 04 Oct 2011 14:18, David Bremner da...@tethera.net writes: So I've pushed the ABI changes, making it more urgent to do something about this. At this point I'm inclined to bump the soname in order to unbreak things, unless someone wants to come up with a convincing set of patches to

Concerns regarding some library functions

2011-09-30 Thread Ali Polatel
Austin Clements yazm??: >Quoth Ali Polatel on Sep 28 at 10:53 am: >> On Tue, 27 Sep 2011 18:46:22 -0400, Austin Clements >> wrote: >> > Quoth David Bremner on Sep 27 at 1:59 pm: >> > > On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel >> > > wrote: >> > > >> > > > The problem with their design

Re: Concerns regarding some library functions

2011-09-30 Thread Ali Polatel
Austin Clements yazmış: Quoth Ali Polatel on Sep 28 at 10:53 am: On Tue, 27 Sep 2011 18:46:22 -0400, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Sep 27 at 1:59 pm: On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel pola...@gmail.com wrote: The problem with their design

Concerns regarding some library functions

2011-09-29 Thread David Bremner
On Thu, 29 Sep 2011 10:51:29 -0400, Austin Clements wrote: > Yes. We could just deal with that (there aren't *that* many API > consumers). For binary compatibility, I suppose we could even use > symbol versioning. I noticed a similar remark in lib/Makefile.local. But I'm not sure how this

Concerns regarding some library functions

2011-09-29 Thread Austin Clements
Quoth David Bremner on Sep 29 at 4:59 pm: > On Thu, 29 Sep 2011 10:51:29 -0400, Austin Clements > wrote: > > > Yes. We could just deal with that (there aren't *that* many API > > consumers). For binary compatibility, I suppose we could even use > > symbol versioning. > > I noticed a similar

Re: Concerns regarding some library functions

2011-09-29 Thread Austin Clements
Quoth Ali Polatel on Sep 28 at 10:53 am: On Tue, 27 Sep 2011 18:46:22 -0400, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Sep 27 at 1:59 pm: On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel pola...@gmail.com wrote: The problem with their design is NULL return may

Re: Concerns regarding some library functions

2011-09-29 Thread David Bremner
On Thu, 29 Sep 2011 10:51:29 -0400, Austin Clements amdra...@mit.edu wrote: Yes. We could just deal with that (there aren't *that* many API consumers). For binary compatibility, I suppose we could even use symbol versioning. I noticed a similar remark in lib/Makefile.local. But I'm not sure

Re: Concerns regarding some library functions

2011-09-29 Thread Austin Clements
Quoth David Bremner on Sep 29 at 4:59 pm: On Thu, 29 Sep 2011 10:51:29 -0400, Austin Clements amdra...@mit.edu wrote: Yes. We could just deal with that (there aren't *that* many API consumers). For binary compatibility, I suppose we could even use symbol versioning. I noticed a

Concerns regarding some library functions

2011-09-28 Thread Sebastian Spaeth
On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel wrote: > The two functions I've mentioned above are > notmuch_database_find_message() and > notmuch_database_find_message_by_filename(). > > The problem with their design is NULL return may both mean an error > condition and "message not found".

Concerns regarding some library functions

2011-09-28 Thread Ali Polatel
On Tue, 27 Sep 2011 18:46:22 -0400, Austin Clements wrote: > Quoth David Bremner on Sep 27 at 1:59 pm: > > On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel > > wrote: > > > > > The problem with their design is NULL return may both mean an error > > > condition and "message not found". However,

Concerns regarding some library functions

2011-09-27 Thread Austin Clements
Quoth David Bremner on Sep 27 at 1:59 pm: > On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel wrote: > > > The problem with their design is NULL return may both mean an error > > condition and "message not found". However, we already have a similar > > function which does not have such a flaw,

Concerns regarding some library functions

2011-09-27 Thread David Bremner
On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel wrote: > The problem with their design is NULL return may both mean an error > condition and "message not found". However, we already have a similar > function which does not have such a flaw, namely > notmuch_database_add_message(). So, I take

Concerns regarding some library functions

2011-09-27 Thread Ali Polatel
Hello, Being the maintainer of Ruby bindings, I've been watching the development of API changes closely. Ruby bindings are nearly complete with the exception of two functions which I think are poorly implemented in terms of error handling. The two functions I've mentioned above are

Re: Concerns regarding some library functions

2011-09-27 Thread Austin Clements
Quoth David Bremner on Sep 27 at 1:59 pm: On Tue, 27 Sep 2011 16:25:58 +0300, Ali Polatel pola...@gmail.com wrote: The problem with their design is NULL return may both mean an error condition and message not found. However, we already have a similar function which does not have such a