Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-22 Thread David Bremner
Keith Amidon writes: > This commit expands docstrings for notmuch-fcc-dirs and > notmuch-maildir-fcc-with-notmuch-insert to describe how quoted strings > are processed and make the ability to configure sent folders containing > whitespace more discoverable. pushed to release and master d __

Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-19 Thread Mark Walters
Hi This version look good to me +1. I recommend it for 0.23.1. Best wishes Mark On Wed, 19 Oct 2016, Keith Amidon wrote: > This commit expands docstrings for notmuch-fcc-dirs and > notmuch-maildir-fcc-with-notmuch-insert to describe how quoted strings > are processed and make the ability t

Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-13 Thread Mark Walters
Hi Many thanks for doing this (and bringing this to out attention). I have a couple of minor suggestions for tweaking what you have written, but I am not certain they are improvements, so comments gratefully received. On Tue, 11 Oct 2016, Keith Amidon wrote: > This commit expands docstrings for

Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-13 Thread Keith Amidon
On Thu, 2016-10-13 at 22:30 -0300, David Bremner wrote: > No technical difficulties, we're just not as good as you think we are > at quick reviews ;). I wanted to hear what Mark felt about exposing > these internals as docstring. I OK with it, but it does make it > slightly harder to change things

Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-13 Thread David Bremner
Keith Amidon writes: > Did my attempt to submit via git send-email the documentation patch > quoted below somehow not get forwarded by the list server? I never got > a copy forwarded by the list but just assumed that it was suppressing > copies to the authors. Having observed that folks here ar

Re: [PATCH] Expand docstrings about fcc using notmuch-insert

2016-10-13 Thread Keith Amidon
Did my attempt to submit via git send-email the documentation patch quoted below somehow not get forwarded by the list server? I never got a copy forwarded by the list but just assumed that it was suppressing copies to the authors. Having observed that folks here are usually very good about revie