Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Austin Clements
Cool. This seems very reasonable. Just some style nits: The three places where you have sanitize_string(, there should be a space between the function name and the paren. Relatedly, for(;*loop;loop++){ should be spaced out like for (; *loop; loop++) {. (Curiously, there seems to be

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Florian Friesdorf
On Sun, 8 May 2011 17:40:54 -0400, Austin Clements amdra...@mit.edu wrote: Cool. This seems very reasonable. Just some style nits: The three places where you have sanitize_string(, there should be a space between the function name and the paren. fixed Relatedly, for(;*loop;loop++){

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Jameson Graef Rollins
Hey, Florian. I applied this patch to release-candidate/0.6, manually adding in the formatting fixes in the same patch. I also applied the test patch, modified to use the add_message test suite function, which makes the patch a bit simpler. Thanks for the fixes. jamie. pgpSo56tz6dHL.pgp