Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-27 Thread David Bremner
Jonas Bernoulli writes: > I have fixed the remaining issues and added two small commits. > See v3. > Great, thanks. I've pushed the main one, and tagged the other two for review. d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-25 Thread Jonas Bernoulli
I have fixed the remaining issues and added two small commits. See v3. > Or of course you can/should get the tests running locally. The problem was that there are incompatible changes in Emacs 27. I am using Emacs 26 for the time being but will look into these breaking changes later. The

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-21 Thread David Bremner
Jonas Bernoulli writes: > David Bremner writes: > >> A quick git grep suggests there are still cl-isms in the test-harness. > > I've fixed that now, see v2. > >> I get 3 test failures > > I am having issues running the tests. Currently > notmuch-mua-send-and-exit in emacs_deliver_message from

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-17 Thread Jonas Bernoulli
David Bremner writes: > A quick git grep suggests there are still cl-isms in the test-harness. I've fixed that now, see v2. > I get 3 test failures I am having issues running the tests. Currently notmuch-mua-send-and-exit in emacs_deliver_message from test-lib.sh just hangs for me. I

Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

2020-04-17 Thread David Bremner
William Casarin writes: > From: Jonas Bernoulli > > Starting with Emacs 27 the old `cl' implementation is finally > considered obsolete. Previously its use was strongly discouraged > at run-time but one was still allowed to use it at compile-time. > > For the most part the transition is very