Re: bug: "no top level messages" crash on Zen email loops

2018-04-28 Thread David Bremner
Antoine Beaupré writes: > Hi! > > Here's a fun bug for you Xapian tricksters. > > Two emails attached make notmuch crash when trying to display the > folder. > > $ notmuch show thread:0001 > Internal error: Thread 0001 has no toplevel messages. >

Re: bug: "no top level messages" crash on Zen email loops

2018-03-29 Thread Olly Betts
On Thu, Mar 29, 2018 at 08:50:22AM -0400, Antoine Beaupré wrote: > On 2018-03-29 04:17:21, Olly Betts wrote: > > If changes to a new database which didn't modify the termlist table were > > committed, then a disk block which had been allocated to be the root > > block in the termlist table was

Re: bug: "no top level messages" crash on Zen email loops

2018-03-29 Thread David Bremner
Antoine Beaupré writes: > Hmm... but if I understand correctly, that's one part of the story: I > could get that error and not have the problem with `notmuch show`. Does > that *also* resolve the issue with email loops? I don't think so, no. d

Re: bug: "no top level messages" crash on Zen email loops

2018-03-29 Thread Antoine Beaupré
On 2018-03-29 04:17:21, Olly Betts wrote: > On Mon, Mar 19, 2018 at 05:03:21PM -0300, David Bremner wrote: >> I can confirm this reproduces both the xapian-check and the notmuch-show >> error. Olly agrees that whatever notmuch is doing wrong, it shouldn't >> lead to a corrupted database > > There

Re: bug: "no top level messages" crash on Zen email loops

2018-03-28 Thread Olly Betts
On Mon, Mar 19, 2018 at 05:03:21PM -0300, David Bremner wrote: > I can confirm this reproduces both the xapian-check and the notmuch-show > error. Olly agrees that whatever notmuch is doing wrong, it shouldn't > lead to a corrupted database There was a Xapian bug here, which I fixed on master

Re: bug: "no top level messages" crash on Zen email loops

2018-03-19 Thread David Bremner
Antoine Beaupré writes: > On 2018-03-19 13:36:49, David Bremner wrote: >> >> I can't duplicate that part. > > That's very strange. I can reproduce this on my workstation here, but > taking the tarball I sent in the original message, I can't reproduce > anymore. So

Re: bug: "no top level messages" crash on Zen email loops

2018-03-19 Thread Antoine Beaupré
And obviously I forget the frigging attachment. zendesk-email-loop2.tgz Description: application/gtar-compressed PS: don't we have a "you forgot to actually attach the damn file" plugin when we detect the word "attachment" and there's no attach? :p

Re: bug: "no top level messages" crash on Zen email loops

2018-03-19 Thread Antoine Beaupré
On 2018-03-19 13:36:49, David Bremner wrote: > Antoine Beaupré writes: > >> Hi! >> >> Here's a fun bug for you Xapian tricksters. >> >> Two emails attached make notmuch crash when trying to display the >> folder. >> >> $ notmuch show thread:0001 >> Internal

Re: bug: "no top level messages" crash on Zen email loops

2018-03-19 Thread David Bremner
Antoine Beaupré writes: > Hi! > > Here's a fun bug for you Xapian tricksters. > > Two emails attached make notmuch crash when trying to display the > folder. > > $ notmuch show thread:0001 > Internal error: Thread 0001 has no toplevel messages. >

bug: "no top level messages" crash on Zen email loops

2018-03-19 Thread Antoine Beaupré
Hi! Here's a fun bug for you Xapian tricksters. Two emails attached make notmuch crash when trying to display the folder. $ notmuch show thread:0001 Internal error: Thread 0001 has no toplevel messages. (notmuch-show.c:1012) Those are the two messages: $ notmuch