bug report: notmuch-hello 'All tags' view

[Michal Sojka]

On Wed, 03 Nov 2010, Jameson Rollins wrote:
> On Wed, 03 Nov 2010 22:57:55 +0100, Michal Sojka  
> wrote:
> > I can confirm this with 0.4 debian package. notmuch search-tags outputs
> > first line as empty and emacs shows it in All tags view.
> 
> Again, this is *not* what I am seeing.  Michael, are you sure you don't
> also have messages tagged with the empty string or blank spaces, as did
> Darren?

Thanks, you are probably right. I should have read your previous mail more
carefully. This was probably caused my initial tagging script which was
fooled by the bug I reported recently in
id:"1288628140-15410-1-git-send-email-sojkam1 at fel.cvut.cz".

-Michal

bug report: notmuch-hello 'All tags' view

[Michal Sojka]

On Tue, 02 Nov 2010 20:17:56 +, Darren McGuicken  wrote:
> Wow, that was probably the most secure bug report in history - this time
> in plain for those of you who don't have access to Carl's private key!
> 
> I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
> 'All tags' view of notmuch-hello which appears to represent a search
> against 'tag:'.  
> 
> For some reason this search matches 1,233 of my now 22,905 messages,
> encompassing a date range of about five years and including an
> apparently random collection of both tagged and untagged threads.
> 
> Anyone else seeing anything similar?  What else do you need from me to
> track this one down?

I can confirm this with 0.4 debian package. notmuch search-tags outputs
first line as empty and emacs shows it in All tags view.

-Michal

bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

On Tue, 02 Nov 2010 17:33:08 -0400, Jameson Rollins  wrote:
> On Tue, 02 Nov 2010 21:03:55 +, Darren McGuicken  fernseed.info> wrote:
> > A call to 'notmuch search-tags' from the command line does indeed
> > return an empty string as the first entry for me[1].
> 
> fwiw, I don't personally get any empty strings in the output of
> search-tags (with 0.4).  So I don't think it's anything inherent to
> that function.

Thanks for the confirmation Jamie - I had a potter with my data and sure
enough, a search for 'tag:""' returned one hit.  I was able to use the
emacs interface to remove the empty string tag from the matching message
('-' then return with no parameters).

So it's probably fair to say that we'll want to handle at least the
empty string scenario as part of our standard tag addition logic since
it can lead to unexpected side effects in searching.

Do we have any other 'known bad' scenarios in tag addition that we want
to catch before I try my hand at a patch?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

bug report: notmuch-hello 'All tags' view

[Jameson Rollins]

On Wed, 03 Nov 2010 22:57:55 +0100, Michal Sojka  wrote:
> I can confirm this with 0.4 debian package. notmuch search-tags outputs
> first line as empty and emacs shows it in All tags view.

Again, this is *not* what I am seeing.  Michael, are you sure you don't
also have messages tagged with the empty string or blank spaces, as did
Darren?

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

Re: bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

On Tue, 02 Nov 2010 17:33:08 -0400, Jameson Rollins 
jroll...@finestructure.net wrote:
 On Tue, 02 Nov 2010 21:03:55 +, Darren McGuicken 
 mailing-notm...@fernseed.info wrote:
  A call to 'notmuch search-tags' from the command line does indeed
  return an empty string as the first entry for me[1].
 
 fwiw, I don't personally get any empty strings in the output of
 search-tags (with 0.4).  So I don't think it's anything inherent to
 that function.

Thanks for the confirmation Jamie - I had a potter with my data and sure
enough, a search for 'tag:' returned one hit.  I was able to use the
emacs interface to remove the empty string tag from the matching message
('-' then return with no parameters).

So it's probably fair to say that we'll want to handle at least the
empty string scenario as part of our standard tag addition logic since
it can lead to unexpected side effects in searching.

Do we have any other 'known bad' scenarios in tag addition that we want
to catch before I try my hand at a patch?


pgp8v0LM0v5sI.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: bug report: notmuch-hello 'All tags' view

[Michal Sojka]

On Tue, 02 Nov 2010 20:17:56 +, Darren McGuicken 
mailing-notm...@fernseed.info wrote:
 Wow, that was probably the most secure bug report in history - this time
 in plain for those of you who don't have access to Carl's private key!
 
 I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
 'All tags' view of notmuch-hello which appears to represent a search
 against 'tag:'.  
 
 For some reason this search matches 1,233 of my now 22,905 messages,
 encompassing a date range of about five years and including an
 apparently random collection of both tagged and untagged threads.
 
 Anyone else seeing anything similar?  What else do you need from me to
 track this one down?

I can confirm this with 0.4 debian package. notmuch search-tags outputs
first line as empty and emacs shows it in All tags view.

-Michal
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: bug report: notmuch-hello 'All tags' view

[Jameson Rollins]

On Wed, 03 Nov 2010 22:57:55 +0100, Michal Sojka sojk...@fel.cvut.cz wrote:
 I can confirm this with 0.4 debian package. notmuch search-tags outputs
 first line as empty and emacs shows it in All tags view.

Again, this is *not* what I am seeing.  Michael, are you sure you don't
also have messages tagged with the empty string or blank spaces, as did
Darren?

jamie.


pgpZs70IubCfy.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

On Tue, 02 Nov 2010 20:17:56 +, Darren McGuicken  wrote:
> I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
> 'All tags' view of notmuch-hello which appears to represent a search
> against 'tag:'.  

Continuing what's turning into an epic one-man list-noise generation
effort, I did a bit more digging and it looks like notmuch-hello
generates the list of tags for the 'All tags' view by processing each
line returned by 'search-tags'.

A call to 'notmuch search-tags' from the command line does indeed return
an empty string as the first entry for me[1].

Does that point to bad data on my part, or has the output of
'search-tags' changed recently?

If the former, any thoughts on how I differentiate an empty tag from
something untagged in a search so I can prune it?


[1] So we have an apparently empty tag being concatenated with a search
string of 'tag:', which actually gives us a search for every message
containing the word 'tag' rather than a tag-based search.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

Wow, that was probably the most secure bug report in history - this time
in plain for those of you who don't have access to Carl's private key!

I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
'All tags' view of notmuch-hello which appears to represent a search
against 'tag:'.  

For some reason this search matches 1,233 of my now 22,905 messages,
encompassing a date range of about five years and including an
apparently random collection of both tagged and untagged threads.

Anyone else seeing anything similar?  What else do you need from me to
track this one down?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

***UNCHECKED*** bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-encrypted
Size: 11 bytes
Desc: not available
URL: 

-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 1729 bytes
Desc: not available
URL: 

bug report: notmuch-hello 'All tags' view

[Jameson Rollins]

On Tue, 02 Nov 2010 21:03:55 +, Darren McGuicken  wrote:
> A call to 'notmuch search-tags' from the command line does indeed return
> an empty string as the first entry for me[1].
> 
> Does that point to bad data on my part, or has the output of
> 'search-tags' changed recently?

fwiw, I don't personally get any empty strings in the output of
search-tags (with 0.4).  So I don't think it's anything inherent to that
function.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

Re: bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

Wow, that was probably the most secure bug report in history - this time
in plain for those of you who don't have access to Carl's private key!

I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
'All tags' view of notmuch-hello which appears to represent a search
against 'tag:'.  

For some reason this search matches 1,233 of my now 22,905 messages,
encompassing a date range of about five years and including an
apparently random collection of both tagged and untagged threads.

Anyone else seeing anything similar?  What else do you need from me to
track this one down?


pgp9O82xxp3p4.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: bug report: notmuch-hello 'All tags' view

[Darren McGuicken]

On Tue, 02 Nov 2010 20:17:56 +, Darren McGuicken 
mailing-notm...@fernseed.info wrote:
 I've noticed since rebasing to 0.4 that I'm seeing an empty entry in the
 'All tags' view of notmuch-hello which appears to represent a search
 against 'tag:'.  

Continuing what's turning into an epic one-man list-noise generation
effort, I did a bit more digging and it looks like notmuch-hello
generates the list of tags for the 'All tags' view by processing each
line returned by 'search-tags'.

A call to 'notmuch search-tags' from the command line does indeed return
an empty string as the first entry for me[1].

Does that point to bad data on my part, or has the output of
'search-tags' changed recently?

If the former, any thoughts on how I differentiate an empty tag from
something untagged in a search so I can prune it?


[1] So we have an apparently empty tag being concatenated with a search
string of 'tag:', which actually gives us a search for every message
containing the word 'tag' rather than a tag-based search.


pgpAb5s6m53Ws.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: bug report: notmuch-hello 'All tags' view

[Jameson Rollins]

On Tue, 02 Nov 2010 21:03:55 +, Darren McGuicken 
mailing-notm...@fernseed.info wrote:
 A call to 'notmuch search-tags' from the command line does indeed return
 an empty string as the first entry for me[1].
 
 Does that point to bad data on my part, or has the output of
 'search-tags' changed recently?

fwiw, I don't personally get any empty strings in the output of
search-tags (with 0.4).  So I don't think it's anything inherent to that
function.

jamie.


pgp1tIh9mWeWD.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch