Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-10 Thread Lars Ingebrigtsen
Eli Zaretskii writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? --

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-10 Thread Noam Postavsky
close 35370 quit Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> I think the patch looks OK -- it'll change the behaviour if you have >> set enable-multibyte-characters to nil, but... does anybody do that? > > If they do, it's their funeral. > > Noam, please go ahead, and thanks. Done.

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-09 Thread Eli Zaretskii
> From: Lars Ingebrigtsen > Cc: Noam Postavsky , da...@tethera.net, > notmuch@notmuchmail.org, d...@fifthhorseman.net, 35...@debbugs.gnu.org > Date: Thu, 09 May 2019 14:33:15 -0400 > > Eli Zaretskii writes: > > > I think so, but I'd be happier if someone from the Gnus folks could > >

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-08 Thread Noam Postavsky
Eli Zaretskii writes: >> From: Daniel Kahn Gillmor >> Date: Sun, 21 Apr 2019 21:55:38 -0400 >> Cc: da...@tethera.net, notmuch@notmuchmail.org, 35...@debbugs.gnu.org >> >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least)

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-07 Thread Eli Zaretskii
> From: Noam Postavsky > Cc: Daniel Kahn Gillmor , da...@tethera.net, > notmuch@notmuchmail.org, 35...@debbugs.gnu.org > Date: Tue, 07 May 2019 08:26:59 -0400 > > > Just remove any uses of it. Why are you using it now? > > Should we remove the remaining uses of it from Emacs too? I think

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Eli Zaretskii
> From: Daniel Kahn Gillmor > Cc: npost...@gmail.com, da...@tethera.net, notmuch@notmuchmail.org, > 35...@debbugs.gnu.org > Date: Mon, 22 Apr 2019 10:21:25 -0400 > > > Just remove any uses of it. Why are you using it now? > > in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Daniel Kahn Gillmor
Hi Eli-- Thanks for the prompt followup! On Mon 2019-04-22 09:33:26 +0300, Eli Zaretskii wrote: > [dkg wrote:] >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Eli Zaretskii
> From: Daniel Kahn Gillmor > Date: Sun, 21 Apr 2019 21:55:38 -0400 > Cc: da...@tethera.net, notmuch@notmuchmail.org, 35...@debbugs.gnu.org > > Do you have any recommendation for how an external emacs module (which > aims to work with at emacs 25 as well at least) should handle this? Just

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Noam Postavsky
Daniel Kahn Gillmor writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 18:05:19 -0400, Noam Postavsky wrote: > The commit which marks this variable as obsolete, has a couple hunks > that just remove uses of it. Not clear why other uses were left in. > Oversight? Thanks, Noam! If that's the right thing for emacs itself, that's good to know. Do

Re: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> When i'm building notmuch in a debian environment with emacs >> 1:26.1+1-3.2, i notice the following deprecation warnings: >> >> In notmuch-maildir-setup-message-for-saving: >>

Re: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread David Bremner
Daniel Kahn Gillmor writes: > When i'm building notmuch in a debian environment with emacs > 1:26.1+1-3.2, i notice the following deprecation warnings: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete

notmuch-emacs: avoiding deprecated message-default-charset

2019-04-20 Thread Daniel Kahn Gillmor
When i'm building notmuch in a debian environment with emacs 1:26.1+1-3.2, i notice the following deprecation warnings: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset