[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-03 Thread David Bremner
On Fri, 2 Mar 2012 15:58:39 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-03-03 Thread David Bremner
On Fri, 2 Mar 2012 15:58:39 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-02 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. The comment is a courtesy of Austin Clements. Signed-off-by: Justus Winter <4winter at

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-02 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. The comment is a courtesy of Austin Clements. Signed-off-by: Justus Winter

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-01 Thread Olly Betts
On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote: > Olly wrote: > >It is hard to say if calling close() is actually useful here from just > >seeing the patch. > > Huh? I provided a test case... I only saw the part of the patch Austin quoted in the mail he cc-ed to me. > Quoting

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-01 Thread Austin Clements
Quoth Justus Winter on Mar 01 at 7:59 am: > Quoting Austin Clements (2012-02-29 23:17:54) > >Quoth Olly Betts on Feb 29 at 9:19 pm: > >> On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > >> > Quoth Justus Winter on Feb 29 at 10:19 am: > >> > > Formerly the xapian database object

[PATCH] Actually close the xapian database in notmuch_database_close

2012-03-01 Thread Justus Winter
Hi :) Olly wrote: >It is hard to say if calling close() is actually useful here from just >seeing the patch. Huh? I provided a test case... Quoting Austin Clements (2012-02-29 23:17:54) >Quoth Olly Betts on Feb 29 at 9:19 pm: >> On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote:

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-03-01 Thread Austin Clements
Quoth Justus Winter on Mar 01 at 7:59 am: Quoting Austin Clements (2012-02-29 23:17:54) Quoth Olly Betts on Feb 29 at 9:19 pm: On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: Quoth Justus Winter on Feb 29 at 10:19 am: Formerly the xapian database object was deleted

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-03-01 Thread Olly Betts
On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote: Olly wrote: It is hard to say if calling close() is actually useful here from just seeing the patch. Huh? I provided a test case... I only saw the part of the patch Austin quoted in the mail he cc-ed to me. Quoting Austin

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Olly Betts
On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > Quoth Justus Winter on Feb 29 at 10:19 am: > > Formerly the xapian database object was deleted and closed in its > > destructor once the object was garbage collected. Explicitly call > > close() so that the database and the

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Olly Betts on Feb 29 at 9:19 pm: > On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: > > Quoth Justus Winter on Feb 29 at 10:19 am: > > > Formerly the xapian database object was deleted and closed in its > > > destructor once the object was garbage collected. Explicitly call

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Justus Winter on Feb 29 at 10:19 am: > Formerly the xapian database object was deleted and closed in its > destructor once the object was garbage collected. Explicitly call > close() so that the database and the associated lock is released > immediately. Interesting. Is this a bug in

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> ---

[PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated lock is released immediately. Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- lib/database.cc |

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Olly Betts
On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: Quoth Justus Winter on Feb 29 at 10:19 am: Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call close() so that the database and the associated

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Austin Clements
Quoth Olly Betts on Feb 29 at 9:19 pm: On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: Quoth Justus Winter on Feb 29 at 10:19 am: Formerly the xapian database object was deleted and closed in its destructor once the object was garbage collected. Explicitly call

Re: [PATCH] Actually close the xapian database in notmuch_database_close

2012-02-29 Thread Justus Winter
Hi :) Olly wrote: It is hard to say if calling close() is actually useful here from just seeing the patch. Huh? I provided a test case... Quoting Austin Clements (2012-02-29 23:17:54) Quoth Olly Betts on Feb 29 at 9:19 pm: On Wed, Feb 29, 2012 at 10:48:33AM -0500, Austin Clements wrote: