[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29 2015, Jinwoo Lee wrote: > On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila wrote: >> On Thu, Jan 29 2015, David Bremner wrote: >> >>> Jinwoo Lee writes: >>> + (shr-blocked-images (if notmuch-show-block-remote-images + "." +

[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 01:39 PM, Jinwoo Lee wrote: > Sent another patch. I couldn't test it with gnus-w3m though because I > don't have w3m on my machine now. I installed w3m and verified that my patch works with gnus-w3m too.

[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:57 PM, Jinwoo Lee wrote: > On Thu, Jan 29, 2015 at 12:25 PM, Tomi Ollila wrote: >> Thanks for your contribution. You seem to have taken my suggestion >> literally just that it IIRC now only sets those when using shr renderer -- >> setting of gnus-blocked images should

[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:25 PM, Tomi Ollila wrote: > On Thu, Jan 29 2015, Jinwoo Lee wrote: > >> On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila wrote: >>> On Thu, Jan 29 2015, David Bremner wrote: >>> Jinwoo Lee writes: > + (shr-blocked-images (if

[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29 2015, David Bremner wrote: > Jinwoo Lee writes: > >> +(shr-blocked-images (if notmuch-show-block-remote-images >> +"." >> + shr-blocked-images))) >> (shr-insert-document dom) >> t)) > > Ideally such a

[PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila wrote: > On Thu, Jan 29 2015, David Bremner wrote: > >> Jinwoo Lee writes: >> >>> + (shr-blocked-images (if notmuch-show-block-remote-images >>> + "." >>> + shr-blocked-images))) >>>

[PATCH] Add a defcustom for whether to block remote images by default.

Jinwoo Lee writes: > + (shr-blocked-images (if notmuch-show-block-remote-images > + "." > + shr-blocked-images))) > (shr-insert-document dom) > t)) Ideally such a customization would apply to all html renders. I think Tomi did

[PATCH] Add a defcustom for whether to block remote images by default.

A defcustom for `notmuch-show-text/html-blocked-images', which is used to set `shr-blocked-images', would be more usable. It can default to "." to achieve the same result. On Thu, Jan 29 2015, Jinwoo Lee wrote: > --- > emacs/notmuch-show.el | 15 +++ > 1 file changed, 11

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com writes: + (shr-blocked-images (if notmuch-show-block-remote-images + . +

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com writes: +(shr-blocked-images (if notmuch-show-block-remote-images +. + shr-blocked-images))) (shr-insert-document dom) t)) Ideally

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29 2015, Jinwoo Lee jinwo...@gmail.com wrote: On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com writes: + (shr-blocked-images (if notmuch-show-block-remote-images +

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:25 PM, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, Jan 29 2015, Jinwoo Lee jinwo...@gmail.com wrote: On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila tomi.oll...@iki.fi wrote: On Thu, Jan 29 2015, David Bremner da...@tethera.net wrote: Jinwoo Lee jinwo...@gmail.com

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 12:57 PM, Jinwoo Lee jinwo...@gmail.com wrote: On Thu, Jan 29, 2015 at 12:25 PM, Tomi Ollila tomi.oll...@iki.fi wrote: Thanks for your contribution. You seem to have taken my suggestion literally just that it IIRC now only sets those when using shr renderer -- setting

Re: [PATCH] Add a defcustom for whether to block remote images by default.

On Thu, Jan 29, 2015 at 01:39 PM, Jinwoo Lee jinwo...@gmail.com wrote: Sent another patch. I couldn't test it with gnus-w3m though because I don't have w3m on my machine now. I installed w3m and verified that my patch works with gnus-w3m too. ___

[PATCH] Add a defcustom for whether to block remote images by default.

--- emacs/notmuch-show.el | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 66350d4..bc48922 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -136,6 +136,11 @@ indentation." :type 'boolean

[PATCH] Add a defcustom for whether to block remote images by default.

--- emacs/notmuch-show.el | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 66350d4..bc48922 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -136,6 +136,11 @@ indentation. :type 'boolean

Re: [PATCH] Add a defcustom for whether to block remote images by default.

A defcustom for `notmuch-show-text/html-blocked-images', which is used to set `shr-blocked-images', would be more usable. It can default to . to achieve the same result. On Thu, Jan 29 2015, Jinwoo Lee wrote: --- emacs/notmuch-show.el | 15 +++ 1 file changed, 11 insertions(+), 4

Re: [PATCH] Add a defcustom for whether to block remote images by default.

Jinwoo Lee jinwo...@gmail.com writes: + (shr-blocked-images (if notmuch-show-block-remote-images + . + shr-blocked-images))) (shr-insert-document dom) t)) Ideally such a customization would apply to all html renders. I