[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
> notmuch-search.c | 453 > +++ > 1 file changed, 326 insertions(+), 127 deletions(-) Hi for such a large patch this was surprisingly easy to follow (though I am not saying I have worked through all the details). However, there are some

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: > On Tue, Jul 10 2012, Mark Walters wrote: > > I think I would also add something saying that the text format is just > > different (and that a significant chunk of the patch is just that). > > Can we not just dump this output format once and

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread cra...@gmx.net
Sorry, the original patch I sent was missing a small part, here the full patch: As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included.

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Austin Clements wrote: > Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: >> On Tue, Jul 10 2012, Mark Walters wrote: >> > I think I would also add something saying that the text format is just >> > different (and that a significant chunk of the patch is just that). >> >>

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Mark Walters wrote: > I think I would also add something saying that the text format is just > different (and that a significant chunk of the patch is just that). Can we not just dump this output format once and for all? Does anything use it? And if so can we just modify

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, craven at gmx.net wrote: > Sorry, the original patch I sent was missing a small part, here the full > patch: > > As discussed in , this patch adds > support for new structured output formats (like s-expressions) by using > stateful structure_printers. An implementation of the

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread craven
Sorry, the original patch I sent was missing a small part, here the full patch: As discussed in id:20120121220407.gk16...@mit.edu, this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
notmuch-search.c | 453 +++ 1 file changed, 326 insertions(+), 127 deletions(-) Hi for such a large patch this was surprisingly easy to follow (though I am not saying I have worked through all the details). However, there are some

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Mark Walters markwalters1...@gmail.com wrote: I think I would also add something saying that the text format is just different (and that a significant chunk of the patch is just that). Can we not just dump this output format once and for all? Does anything use it? And if

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: On Tue, Jul 10 2012, Mark Walters markwalters1...@gmail.com wrote: I think I would also add something saying that the text format is just different (and that a significant chunk of the patch is just that). Can we not just dump this output

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Austin Clements amdra...@mit.edu wrote: Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: On Tue, Jul 10 2012, Mark Walters markwalters1...@gmail.com wrote: I think I would also add something saying that the text format is just different (and that a significant chunk of