[PATCH] Return error status from notmuch_message_tags_to_maildir_flags().
Looks good to me, but it appears that both callers of notmuch_message_tags_to_maildir_flags ignore the return value. Both callers synchronize maildir flags immediately after thawing the tag changes on a message. Perhaps they should instead synchronize *before* thawing and abort if the sync fails? On Tue, Feb 15, 2011 at 1:07 AM, Rob Browning wrote: > Signed-off-by: Rob Browning > --- > ?lib/message.cc | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/message.cc b/lib/message.cc > index 0590f76..979fad5 100644 > --- a/lib/message.cc > +++ b/lib/message.cc > @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags > (notmuch_message_t *message) > ? ? talloc_free (to_set); > ? ? talloc_free (to_clear); > > - ? ?return NOTMUCH_STATUS_SUCCESS; > + ? ?return status; > ?} > > ?notmuch_status_t > -- > 1.7.2.3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch >
Re: [PATCH] Return error status from notmuch_message_tags_to_maildir_flags().
Looks good to me, but it appears that both callers of notmuch_message_tags_to_maildir_flags ignore the return value. Both callers synchronize maildir flags immediately after thawing the tag changes on a message. Perhaps they should instead synchronize *before* thawing and abort if the sync fails? On Tue, Feb 15, 2011 at 1:07 AM, Rob Browning wrote: > Signed-off-by: Rob Browning > --- > lib/message.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/message.cc b/lib/message.cc > index 0590f76..979fad5 100644 > --- a/lib/message.cc > +++ b/lib/message.cc > @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags > (notmuch_message_t *message) > talloc_free (to_set); > talloc_free (to_clear); > > - return NOTMUCH_STATUS_SUCCESS; > + return status; > } > > notmuch_status_t > -- > 1.7.2.3 > > ___ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch > ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] Return error status from notmuch_message_tags_to_maildir_flags().
Signed-off-by: Rob Browning --- lib/message.cc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index 0590f76..979fad5 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_message_t *message) talloc_free (to_set); talloc_free (to_clear); -return NOTMUCH_STATUS_SUCCESS; +return status; } notmuch_status_t -- 1.7.2.3
[PATCH] Return error status from notmuch_message_tags_to_maildir_flags().
Signed-off-by: Rob Browning --- lib/message.cc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/message.cc b/lib/message.cc index 0590f76..979fad5 100644 --- a/lib/message.cc +++ b/lib/message.cc @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_message_t *message) talloc_free (to_set); talloc_free (to_clear); -return NOTMUCH_STATUS_SUCCESS; +return status; } notmuch_status_t -- 1.7.2.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
