Re: [PATCH] Test: fix draft test for emacs23
Mark Walters writes: > emacs24 and emacs23 have different secure tag defaults: in particular, > mml-secure-message-sign only signs the part on emacs23 but the whole > message on emacs24. This difference makes one of the draft tests fail > (which causes a cascade of later failures) on emacs23. It seems that > travis uses emacs23 so it is useful to fix this. > > We do this by forcing the whole message to be signed in either case -- > the code snippet is extracted from mml-secure-message-sign on emacs24. > --- Pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Test: fix draft test for emacs23
On Mon, Nov 14 2016, David Bremner wrote: > Mark Walters writes: > >> emacs24 and emacs23 have different secure tag defaults: in particular, >> mml-secure-message-sign only signs the part on emacs23 but the whole >> message on emacs24. This difference makes one of the draft tests fail >> (which causes a cascade of later failures) on emacs23. It seems that >> travis uses emacs23 so it is useful to fix this. >> >> We do this by forcing the whole message to be signed in either case -- >> the code snippet is extracted from mml-secure-message-sign on emacs24. >> --- > > Fixes the tests on emacs 23 for me, without the other other emacs23 > compatibility patch > > It's a little ugly, but it's the test suite. So I guess we go for it. If you refer tabs converted to spaces then I agree on ugliness >;) +1 > > d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Test: fix draft test for emacs23
Mark Walters writes: > emacs24 and emacs23 have different secure tag defaults: in particular, > mml-secure-message-sign only signs the part on emacs23 but the whole > message on emacs24. This difference makes one of the draft tests fail > (which causes a cascade of later failures) on emacs23. It seems that > travis uses emacs23 so it is useful to fix this. > > We do this by forcing the whole message to be signed in either case -- > the code snippet is extracted from mml-secure-message-sign on emacs24. > --- Fixes the tests on emacs 23 for me, without the other other emacs23 compatibility patch It's a little ugly, but it's the test suite. So I guess we go for it. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] Test: fix draft test for emacs23
emacs24 and emacs23 have different secure tag defaults: in particular, mml-secure-message-sign only signs the part on emacs23 but the whole message on emacs24. This difference makes one of the draft tests fail (which causes a cascade of later failures) on emacs23. It seems that travis uses emacs23 so it is useful to fix this. We do this by forcing the whole message to be signed in either case -- the code snippet is extracted from mml-secure-message-sign on emacs24. --- The main thing to note with this is that the motivation for fixing is that travis seems to use emacs23. Best wishes Mark test/T630-emacs-draft.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/T630-emacs-draft.sh b/test/T630-emacs-draft.sh index 46fc356..cd9e33a 100755 --- a/test/T630-emacs-draft.sh +++ b/test/T630-emacs-draft.sh @@ -32,7 +32,9 @@ test_begin_subtest "Saving a signed draft adds header" test_emacs '(notmuch-mua-mail) (message-goto-subject) (insert "draft-test-0003") - (mml-secure-message-sign) +;; We would use (mml-secure-message-sign) but on emacs23 +;; that only signs the part, not the whole message. +(mml-secure-message mml-secure-method '\''sign) (notmuch-draft-save) (test-output)' header_count=$(notmuch show --format=raw subject:draft-test-0003 | grep -c ^X-Notmuch-Emacs-Secure) -- 2.1.4 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
