[PATCH] cli: abstract common config get/set code

2014-01-18 Thread David Bremner
Jani Nikula writes: > Pretty straightforward abstraction similar to get/set list. > pushed. d

[PATCH] cli: abstract common config get/set code

2014-01-18 Thread Tomi Ollila
On Fri, Jan 17 2014, Jani Nikula wrote: > Pretty straightforward abstraction similar to get/set list. > > --- LGTM. tests pass. > > v2 of id:1376839205-5115-1-git-send-email-jani at nikula.org adding a few > comments about config value caching per David's request. Dropped the > 2nd patch as

[PATCH] cli: abstract common config get/set code

2014-01-18 Thread Mark Walters
LGTM too Mark On Sat, 18 Jan 2014, Tomi Ollila wrote: > On Fri, Jan 17 2014, Jani Nikula wrote: > >> Pretty straightforward abstraction similar to get/set list. >> >> --- > > LGTM. tests pass. > >> >> v2 of id:1376839205-5115-1-git-send-email-jani at nikula.org adding a few >> comments about

Re: [PATCH] cli: abstract common config get/set code

2014-01-18 Thread Tomi Ollila
On Fri, Jan 17 2014, Jani Nikula j...@nikula.org wrote: Pretty straightforward abstraction similar to get/set list. --- LGTM. tests pass. v2 of id:1376839205-5115-1-git-send-email-j...@nikula.org adding a few comments about config value caching per David's request. Dropped the 2nd patch

Re: [PATCH] cli: abstract common config get/set code

2014-01-18 Thread Mark Walters
LGTM too Mark On Sat, 18 Jan 2014, Tomi Ollila tomi.oll...@iki.fi wrote: On Fri, Jan 17 2014, Jani Nikula j...@nikula.org wrote: Pretty straightforward abstraction similar to get/set list. --- LGTM. tests pass. v2 of id:1376839205-5115-1-git-send-email-j...@nikula.org adding a few

Re: [PATCH] cli: abstract common config get/set code

2014-01-18 Thread David Bremner
Jani Nikula j...@nikula.org writes: Pretty straightforward abstraction similar to get/set list. pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] cli: abstract common config get/set code

2014-01-17 Thread Jani Nikula
Pretty straightforward abstraction similar to get/set list. --- v2 of id:1376839205-5115-1-git-send-email-jani at nikula.org adding a few comments about config value caching per David's request. Dropped the 2nd patch as too tricky. --- notmuch-config.c | 86

[PATCH] cli: abstract common config get/set code

2014-01-17 Thread Jani Nikula
Pretty straightforward abstraction similar to get/set list. --- v2 of id:1376839205-5115-1-git-send-email-j...@nikula.org adding a few comments about config value caching per David's request. Dropped the 2nd patch as too tricky. --- notmuch-config.c | 86