Re: [PATCH] cli: use designated initializers for opt desc

2017-10-01 Thread Jani Nikula
On Sun, 01 Oct 2017, Tomi Ollila wrote: > On Sun, Oct 01 2017, Jani Nikula wrote: > >> On Sun, 01 Oct 2017, Tomi Ollila wrote: >>> >>> Good stuff. It just doesn't longer compile on older compilers (so some >>> note on commit message should be added): >> >>

Re: [PATCH] cli: use designated initializers for opt desc

2017-10-01 Thread Tomi Ollila
On Sun, Oct 01 2017, Jani Nikula wrote: > On Sun, 01 Oct 2017, Tomi Ollila wrote: >> >> Good stuff. It just doesn't longer compile on older compilers (so some >> note on commit message should be added): > > Does this on top fix it? I used the unnamed struct just for clarity,

Re: [PATCH] cli: use designated initializers for opt desc

2017-10-01 Thread Jani Nikula
On Sun, 01 Oct 2017, Tomi Ollila wrote: > On Sun, Oct 01 2017, Jani Nikula wrote: > >> Several changes at once, just to not have to change the same lines >> several times over: >> >> - Use designated initializers to initialize opt desc arrays. >> >> - Only initialize the

Re: [PATCH] cli: use designated initializers for opt desc

2017-10-01 Thread Tomi Ollila
On Sun, Oct 01 2017, Jani Nikula wrote: > Several changes at once, just to not have to change the same lines > several times over: > > - Use designated initializers to initialize opt desc arrays. > > - Only initialize the needed fields. > > - Remove arg_id (short options) as unused. > > - Replace

Re: [PATCH] cli: use designated initializers for opt desc

2017-10-01 Thread David Bremner
Jani Nikula writes: > Several changes at once, just to not have to change the same lines > several times over: the general approach here looks fine. I didn't see any blockers, but I'll wait a few days before merging. This probably causes some rebasing pain for other people,

[PATCH] cli: use designated initializers for opt desc

2017-09-30 Thread Jani Nikula
Several changes at once, just to not have to change the same lines several times over: - Use designated initializers to initialize opt desc arrays. - Only initialize the needed fields. - Remove arg_id (short options) as unused. - Replace opt_type and output_var with several type safe output