Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-09-03 Thread David Bremner
Antoine Beaupré  writes:

> This enables auto-completion of commands, something which plain
> read-string does not do. It's otherwise a drop-in
> replacement. According to `C-h f`, read-shell-command was introduced
> in Emacs 23.1 or earlier.

Applied to master.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-08-31 Thread Tomi Ollila
On Tue, Aug 30 2022, Antoine Beaupré wrote:

> This enables auto-completion of commands, something which plain
> read-string does not do. It's otherwise a drop-in
> replacement. According to `C-h f`, read-shell-command was introduced
> in Emacs 23.1 or earlier.

LGTM.

Tomi

> ---
>  emacs/notmuch-show.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 2dcef981..ec998ede 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2192,7 +2192,7 @@ message."
>(interactive (let ((query-string (if current-prefix-arg
>  "Pipe all open messages to command: "
>"Pipe message to command: ")))
> -  (list current-prefix-arg (read-string query-string
> +  (list current-prefix-arg (read-shell-command query-string
>(let (shell-command)
>  (if entire-thread
>   (setq shell-command
> -- 
> 2.30.2
>
> ___
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-le...@notmuchmail.org
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


[PATCH] emacs/show: use read-shell-command instead of read-string

2022-08-30 Thread Antoine Beaupré
This enables auto-completion of commands, something which plain
read-string does not do. It's otherwise a drop-in
replacement. According to `C-h f`, read-shell-command was introduced
in Emacs 23.1 or earlier.
---
 emacs/notmuch-show.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 2dcef981..ec998ede 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2192,7 +2192,7 @@ message."
   (interactive (let ((query-string (if current-prefix-arg
   "Pipe all open messages to command: "
 "Pipe message to command: ")))
-(list current-prefix-arg (read-string query-string
+(list current-prefix-arg (read-shell-command query-string
   (let (shell-command)
 (if entire-thread
(setq shell-command
-- 
2.30.2

___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org