[PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread Aneesh Kumar K. V 
On Fri, 19 Nov 2010 16:06:40 +, David Edmondson  wrote:
> On Fri, 19 Nov 2010 21:31:36 +0530, "Aneesh Kumar K. V"  linux.vnet.ibm.com> wrote:
> > On Tue, 16 Nov 2010 17:51:38 +, David Edmondson  wrote:
> > > Message mode uses a different name for composition buffers in newer
> > > versions of emacs. Allow for this when causing the composition window
> > > to overlay the viewing window.
> > > ---
> > > 
> > > I don't understand why Aneesh chose to use `add-hook' and `purecopy'.
> > 
> > So what when i have unset mail added via .emacs even the older version
> > will work. making sure if the name change again i can fix it by a .emacs
> > update rather than notmuch code update.
> 
> What would you add to .emacs?
> 

In custom-set-variable i have the below

 '(same-window-buffer-names (quote ("*unsent mail*" "*shell*" "*mail*" 
"*inferior-lisp*" "*ielm*" "*scheme*")))
 '(same-window-regexps (quote ("\\*rsh-[^-]*\\*\\(\\|<[0-9]*>\\)" 
"\\*telnet-.*\\*\\(\\|<[0-9]+>\\)" "^\\*rlogin-.*\\*\\(\\|<[0-9]+>\\)" 
"\\*info\\*\\(\\|<[0-9]+>\\)" "\\*gud-.*\\*\\(\\|<[0-9]+>\\)" 
"\\`\\*Customiz.*\\*\\'" "\\*unsent mail .*")))


-aneesh

[PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread Aneesh Kumar K. V 
On Tue, 16 Nov 2010 17:51:38 +, David Edmondson  wrote:
> Message mode uses a different name for composition buffers in newer
> versions of emacs. Allow for this when causing the composition window
> to overlay the viewing window.
> ---
> 
> I don't understand why Aneesh chose to use `add-hook' and `purecopy'.

So what when i have unset mail added via .emacs even the older version
will work. making sure if the name change again i can fix it by a .emacs
update rather than notmuch code update.



> 
>  emacs/notmuch-mua.el |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index dc7b386..70c8dff 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -88,7 +88,7 @@ list."
>  (let
>   ;; Overlay the composition window on that being used to read
>   ;; the original message.
> - ((same-window-regexps '("\\*mail .*")))
> + ((same-window-regexps '("\\*mail .*" "\\*unsent mail .*")))
>(notmuch-mua-mail (mail-header 'to headers)
>   (mail-header 'subject headers)
>   (message-headers-to-generate headers t '(to subject


-aneesh

[PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread David Edmondson 
On Fri, 19 Nov 2010 22:05:25 +0530, "Aneesh Kumar K. V"  wrote:
> > > > I don't understand why Aneesh chose to use `add-hook' and `purecopy'.
> > > 
> > > So what when i have unset mail added via .emacs even the older version
> > > will work. making sure if the name change again i can fix it by a .emacs
> > > update rather than notmuch code update.
> > 
> > What would you add to .emacs?
> > 
> 
> In custom-set-variable i have the below
> 
>  '(same-window-buffer-names (quote ("*unsent mail*" "*shell*" "*mail*" 
> "*inferior-lisp*" "*ielm*" "*scheme*")))
>  '(same-window-regexps (quote ("\\*rsh-[^-]*\\*\\(\\|<[0-9]*>\\)" 
> "\\*telnet-.*\\*\\(\\|<[0-9]+>\\)" "^\\*rlogin-.*\\*\\(\\|<[0-9]+>\\)" 
> "\\*info\\*\\(\\|<[0-9]+>\\)" "\\*gud-.*\\*\\(\\|<[0-9]+>\\)" 
> "\\`\\*Customiz.*\\*\\'" "\\*unsent mail .*")))

I see. So you want a solution that _augments_ the existing value of
`same-window-regexps' in `notmuch-mua-reply' rather than overriding it?

dme.
-- 
David Edmondson, http://dme.org
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

[PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread David Edmondson 
On Fri, 19 Nov 2010 21:31:36 +0530, "Aneesh Kumar K. V"  wrote:
> On Tue, 16 Nov 2010 17:51:38 +, David Edmondson  wrote:
> > Message mode uses a different name for composition buffers in newer
> > versions of emacs. Allow for this when causing the composition window
> > to overlay the viewing window.
> > ---
> > 
> > I don't understand why Aneesh chose to use `add-hook' and `purecopy'.
> 
> So what when i have unset mail added via .emacs even the older version
> will work. making sure if the name change again i can fix it by a .emacs
> update rather than notmuch code update.

What would you add to .emacs?

dme.
-- 
David Edmondson, http://dme.org
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

Re: [PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread Aneesh Kumar K. V 
On Tue, 16 Nov 2010 17:51:38 +, David Edmondson d...@dme.org wrote:
 Message mode uses a different name for composition buffers in newer
 versions of emacs. Allow for this when causing the composition window
 to overlay the viewing window.
 ---
 
 I don't understand why Aneesh chose to use `add-hook' and `purecopy'.

So what when i have unset mail added via .emacs even the older version
will work. making sure if the name change again i can fix it by a .emacs
update rather than notmuch code update.



 
  emacs/notmuch-mua.el |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
 index dc7b386..70c8dff 100644
 --- a/emacs/notmuch-mua.el
 +++ b/emacs/notmuch-mua.el
 @@ -88,7 +88,7 @@ list.
  (let
   ;; Overlay the composition window on that being used to read
   ;; the original message.
 - ((same-window-regexps '(\\*mail .*)))
 + ((same-window-regexps '(\\*mail .* \\*unsent mail .*)))
(notmuch-mua-mail (mail-header 'to headers)
   (mail-header 'subject headers)
   (message-headers-to-generate headers t '(to subject


-aneesh
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread David Edmondson 
On Fri, 19 Nov 2010 21:31:36 +0530, Aneesh Kumar K. V 
aneesh.ku...@linux.vnet.ibm.com wrote:
 On Tue, 16 Nov 2010 17:51:38 +, David Edmondson d...@dme.org wrote:
  Message mode uses a different name for composition buffers in newer
  versions of emacs. Allow for this when causing the composition window
  to overlay the viewing window.
  ---
  
  I don't understand why Aneesh chose to use `add-hook' and `purecopy'.
 
 So what when i have unset mail added via .emacs even the older version
 will work. making sure if the name change again i can fix it by a .emacs
 update rather than notmuch code update.

What would you add to .emacs?

dme.
-- 
David Edmondson, http://dme.org


pgpouZzRSB5M4.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Accommodate message-mode updates.

2010-11-19 Thread Aneesh Kumar K. V 
On Fri, 19 Nov 2010 16:06:40 +, David Edmondson d...@dme.org wrote:
 On Fri, 19 Nov 2010 21:31:36 +0530, Aneesh Kumar K. V 
 aneesh.ku...@linux.vnet.ibm.com wrote:
  On Tue, 16 Nov 2010 17:51:38 +, David Edmondson d...@dme.org wrote:
   Message mode uses a different name for composition buffers in newer
   versions of emacs. Allow for this when causing the composition window
   to overlay the viewing window.
   ---
   
   I don't understand why Aneesh chose to use `add-hook' and `purecopy'.
  
  So what when i have unset mail added via .emacs even the older version
  will work. making sure if the name change again i can fix it by a .emacs
  update rather than notmuch code update.
 
 What would you add to .emacs?
 

In custom-set-variable i have the below

 '(same-window-buffer-names (quote (*unsent mail* *shell* *mail* 
*inferior-lisp* *ielm* *scheme*)))
 '(same-window-regexps (quote (\\*rsh-[^-]*\\*\\(\\|[0-9]*\\) 
\\*telnet-.*\\*\\(\\|[0-9]+\\) ^\\*rlogin-.*\\*\\(\\|[0-9]+\\) 
\\*info\\*\\(\\|[0-9]+\\) \\*gud-.*\\*\\(\\|[0-9]+\\) 
\\`\\*Customiz.*\\*\\' \\*unsent mail .*)))


-aneesh
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Accommodate message-mode updates.

2010-11-16 Thread David Edmondson 
Message mode uses a different name for composition buffers in newer
versions of emacs. Allow for this when causing the composition window
to overlay the viewing window.
---

I don't understand why Aneesh chose to use `add-hook' and `purecopy'.

 emacs/notmuch-mua.el |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index dc7b386..70c8dff 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -88,7 +88,7 @@ list."
 (let
;; Overlay the composition window on that being used to read
;; the original message.
-   ((same-window-regexps '("\\*mail .*")))
+   ((same-window-regexps '("\\*mail .*" "\\*unsent mail .*")))
   (notmuch-mua-mail (mail-header 'to headers)
(mail-header 'subject headers)
(message-headers-to-generate headers t '(to subject
-- 
1.7.2.3

[PATCH] emacs: Accommodate message-mode updates.

2010-11-16 Thread David Edmondson 
Message mode uses a different name for composition buffers in newer
versions of emacs. Allow for this when causing the composition window
to overlay the viewing window.
---

I don't understand why Aneesh chose to use `add-hook' and `purecopy'.

 emacs/notmuch-mua.el |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index dc7b386..70c8dff 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -88,7 +88,7 @@ list.
 (let
;; Overlay the composition window on that being used to read
;; the original message.
-   ((same-window-regexps '(\\*mail .*)))
+   ((same-window-regexps '(\\*mail .* \\*unsent mail .*)))
   (notmuch-mua-mail (mail-header 'to headers)
(mail-header 'subject headers)
(message-headers-to-generate headers t '(to subject
-- 
1.7.2.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch