[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 07:22:42 +, David Edmondson wrote: > On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner > wrote: > > I'm leaning to revert this patch. Any opposition? > > Please revert it and I'll investigate further. Reverted. d

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-17 Thread David Edmondson
On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner wrote: > I'm leaning to revert this patch. Any opposition? Please revert it and I'll investigate further. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-17 Thread David Bremner
On Tue, 17 Jan 2012 07:22:42 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner da...@tethera.net wrote: I'm leaning to revert this patch. Any opposition? Please revert it and I'll investigate further. Reverted. d

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay wrote: > On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet > > wrote: > > > Alas, those text properties actually *were* effective (and I liked them :) > > > > Well, not in emacs 24. My

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay wrote: > On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet > > wrote: > > > Alas, those text properties actually *were* effective (and I liked them :) > > > > Well, not in emacs 24. My

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Aaron Ecay
On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > > Alas, those text properties actually *were* effective (and I liked them :) > > Well, not in emacs 24. My reading of the source was that overlays were > intended to stomp on

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 11:22:27 +, David Edmondson wrote: > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > > Alas, those text properties actually *were* effective (and I liked them :) > > Well, not in emacs 24. My reading of the source was that overlays were > intended to stomp on

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Pieter Praet
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson wrote: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- >

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet wrote: > Alas, those text properties actually *were* effective (and I liked them :) Well, not in emacs 24. My reading of the source was that overlays were intended to stomp on text properties, but that could have been wrong. Do they look correct

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Pieter Praet
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson d...@dme.org wrote: The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. ---

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet pie...@praet.org wrote: Alas, those text properties actually *were* effective (and I liked them :) Well, not in emacs 24. My reading of the source was that overlays were intended to stomp on text properties, but that could have been wrong. Do

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread Jani Nikula
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay aarone...@gmail.com wrote: On Mon, 16 Jan 2012 11:22:27 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet pie...@praet.org wrote: Alas, those text properties actually *were* effective (and I liked them

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay aarone...@gmail.com wrote: On Mon, 16 Jan 2012 11:22:27 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet pie...@praet.org wrote: Alas, those text properties actually *were* effective (and I liked them

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-16 Thread David Edmondson
On Mon, 16 Jan 2012 18:21:24 -0400, David Bremner da...@tethera.net wrote: I'm leaning to revert this patch. Any opposition? Please revert it and I'll investigate further. pgp2sWrScOERx.pgp Description: PGP signature ___ notmuch mailing list

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-15 Thread David Bremner
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson wrote: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. Pushed. d

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2012-01-15 Thread David Bremner
On Tue, 27 Dec 2011 16:47:14 +, David Edmondson d...@dme.org wrote: The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen.

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Xavier Maillard
On Wed, 28 Dec 2011 12:09:40 -0800, Jameson Graef Rollins wrote: > On Wed, 28 Dec 2011 13:42:28 +0100, Xavier Maillard > wrote: > > On Tue, 27 Dec 2011 22:29:57 -0500, Austin Clements > > wrote: > > > LGTM. > > > > uh, what ? > > http://www.google.com/search?q=LGTM LGTM too no :D /Xavier

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Xavier Maillard
Hi David, On Tue, 27 Dec 2011 16:47:14 +, David Edmondson wrote: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen.

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Xavier Maillard
On Tue, 27 Dec 2011 22:29:57 -0500, Austin Clements wrote: > LGTM. uh, what ? /Xavier

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Jameson Graef Rollins
On Wed, 28 Dec 2011 13:42:28 +0100, Xavier Maillard wrote: > On Tue, 27 Dec 2011 22:29:57 -0500, Austin Clements > wrote: > > LGTM. > > uh, what ? http://www.google.com/search?q=LGTM

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Jameson Graef Rollins
On Wed, 28 Dec 2011 13:42:28 +0100, Xavier Maillard xav...@maillard.im wrote: On Tue, 27 Dec 2011 22:29:57 -0500, Austin Clements amdra...@mit.edu wrote: LGTM. uh, what ? http://www.google.com/search?q=LGTM ___ notmuch mailing list

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-28 Thread Xavier Maillard
On Wed, 28 Dec 2011 12:09:40 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Wed, 28 Dec 2011 13:42:28 +0100, Xavier Maillard xav...@maillard.im wrote: On Tue, 27 Dec 2011 22:29:57 -0500, Austin Clements amdra...@mit.edu wrote: LGTM. uh, what ?

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread Austin Clements
LGTM. Quoth David Edmondson on Dec 27 at 4:47 pm: > The tags were coloured using text properties. Unfortunately that text > (the header line) also has an overlay, which overrides the text > properties. There's not point in applying text properties that will > never be seen. > --- >

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread David Edmondson
The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. --- emacs/notmuch-show.el |8 ++-- 1 files changed, 2 insertions(+), 6

[PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread David Edmondson
The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. --- emacs/notmuch-show.el |8 ++-- 1 files changed, 2 insertions(+), 6

Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

2011-12-27 Thread Austin Clements
LGTM. Quoth David Edmondson on Dec 27 at 4:47 pm: The tags were coloured using text properties. Unfortunately that text (the header line) also has an overlay, which overrides the text properties. There's not point in applying text properties that will never be seen. ---