Re: [PATCH] emacs: use query name for tree saved-search buffer names
Jose Antonio Ortega Ruiz writes: > On Sun, Jan 09 2022, David Bremner wrote: >> >> 1) Should this actually approximate what we do in >>#'notmuch-search-buffer-title ? The buffer gets a name like >>"*notmuch-saved-search-inbox*" > oh, you're right. i have that function advised (because i prefer using > the unadorned query name), and thought i was being consistent. i think > we should. maybe we could consider adding a customizable format string > with default "*notmuch-saved-search-inbox-%s*" for cases like mine? Yes, sounds reasonable. > >> 2) Should we do the same thing (whatever that is) for unthreaded mode >>searches? > > i don't see any reason not to. i'll be happy to send a patch for both > cases. sounds good. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: use query name for tree saved-search buffer names
On Sun, Jan 09 2022, David Bremner wrote: > jao writes: > >> This simply mimics what we already do for non-tree searches, and makes >> up for nicer buffer names. Note that this patch only applies to >> queries not coming from a search widget in the hello buffer. >> > > Two questions: > > 1) Should this actually approximate what we do in >#'notmuch-search-buffer-title ? The buffer gets a name like >"*notmuch-saved-search-inbox*" oh, you're right. i have that function advised (because i prefer using the unadorned query name), and thought i was being consistent. i think we should. maybe we could consider adding a customizable format string with default "*notmuch-saved-search-inbox-%s*" for cases like mine? > 2) Should we do the same thing (whatever that is) for unthreaded mode >searches? i don't see any reason not to. i'll be happy to send a patch for both cases. cheers, jao -- Whenever you commend, add your reasons for doing so; it is this which distinguishes the approbation of a man of sense from the flattery of sycophants and admiration of fools. -Richard Steele (1672-1729) ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: use query name for tree saved-search buffer names
jao writes: > This simply mimics what we already do for non-tree searches, and makes > up for nicer buffer names. Note that this patch only applies to > queries not coming from a search widget in the hello buffer. > Two questions: 1) Should this actually approximate what we do in #'notmuch-search-buffer-title ? The buffer gets a name like "*notmuch-saved-search-inbox*" 2) Should we do the same thing (whatever that is) for unthreaded mode searches? d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH] emacs: use query name for tree saved-search buffer names
On Sat, Jan 08 2022, jao wrote: > This simply mimics what we already do for non-tree searches, and makes > up for nicer buffer names. Note that this patch only applies to > queries not coming from a search widget in the hello buffer. sorry, i meant "queries *coming* from a search widget" ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH] emacs: use query name for tree saved-search buffer names
This simply mimics what we already do for non-tree searches, and makes up for nicer buffer names. Note that this patch only applies to queries not coming from a search widget in the hello buffer. Signed-off-by: jao --- emacs/notmuch-hello.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index fc007c4c..9f42a90b 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -487,7 +487,7 @@ diagonal." (cl-case (widget-get widget :notmuch-search-type) (tree (notmuch-tree (widget-get widget :notmuch-search-terms) - nil nil nil nil nil nil + nil nil (widget-value widget) nil nil nil (widget-get widget :notmuch-search-oldest-first))) (unthreaded (notmuch-unthreaded (widget-get widget :notmuch-search-terms))) -- 2.34.1 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
