Re: [PATCH] lib/message-file: close stream in destructor

2019-05-10 Thread David Bremner
David Bremner writes: > Without this, > > $ make time-test OPTIONS=--small > > leads to fatal errors from too many open files. > > Thanks to st-gourichon-fid for bringing this problem to my attention in IRC. > --- > lib/message-file.c | 3 +++ > 1 file changed, 3 insertions(+) > > The

Re: [PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread David Bremner
Will Dietz writes: > Great, thank you! > > Much appreciated, I actually was running into this yesterday. > > ( which for whatever reason led to posting this on the subject: > https://github.com/afewmail/afew/issues/193#issuecomment-490766850 ) > > Would the valgrind support in the test suite

Re: [PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread Will Dietz
Great, thank you! Much appreciated, I actually was running into this yesterday. ( which for whatever reason led to posting this on the subject: https://github.com/afewmail/afew/issues/193#issuecomment-490766850 ) Would the valgrind support in the test suite catch this sort of thing (fd leak on

[PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread David Bremner
Without this, $ make time-test OPTIONS=--small leads to fatal errors from too many open files. Thanks to st-gourichon-fid for bringing this problem to my attention in IRC. --- lib/message-file.c | 3 +++ 1 file changed, 3 insertions(+) The regression test could be improved, but I wanted to