[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-04 Thread David Bremner
"J. Lewis Muir" writes: > > I'm sorry for the confusing commit message. As per David's subsequent > email on this thread, I'll try submitting again with a better one. > Just for the record, I appreciate the effort to explain the problem. One convention that might be useful is that additional c

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-04 Thread David Bremner
"J. Lewis Muir" writes: > > I'm sorry for the confusing commit message. As per David's subsequent > email on this thread, I'll try submitting again with a better one. > Just for the record, I appreciate the effort to explain the problem. One convention that might be useful is that additional c

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-04 Thread J. Lewis Muir
On 2/26/15 1:04 PM, Tomi Ollila wrote: > The commit message is just (IMO) somewhat confusing; what is this > > $ otool -L /opt/notmuch-current/lib/libnotmuch.dylib > > is there files /opt/notmuch-current/lib/libnotmuch.dylib and > /opt/notmuch-current/lib/libnotmuch.3.dylib in the fs Hi, Tomi.

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-03-04 Thread J. Lewis Muir
On 2/26/15 1:04 PM, Tomi Ollila wrote: > The commit message is just (IMO) somewhat confusing; what is this > > $ otool -L /opt/notmuch-current/lib/libnotmuch.dylib > > is there files /opt/notmuch-current/lib/libnotmuch.dylib and > /opt/notmuch-current/lib/libnotmuch.3.dylib in the fs Hi, Tomi.

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-27 Thread David Bremner
"J. Lewis Muir" writes: I think Tomi and I agree the content of the patch is OK, or at least as far as we can verify. If you don't mind, could you rework the commit message a bit? this part is fine: > The install_name of libnotmuch.dylib on Mac OS X is what is written > into a program that link

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-27 Thread David Bremner
"J. Lewis Muir" writes: I think Tomi and I agree the content of the patch is OK, or at least as far as we can verify. If you don't mind, could you rework the commit message a bit? this part is fine: > The install_name of libnotmuch.dylib on Mac OS X is what is written > into a program that link

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread Tomi Ollila
On Thu, Feb 26 2015, "J. Lewis Muir" wrote: > On 2/25/15 1:34 AM, David Bremner wrote: >> Unfortunately we did not receive any feedback from Mac users in the >> meantime. It would be nice to know that your patch won't break the >> existing macports and brew packages. I suppose that those work >>

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread J. Lewis Muir
On 2/25/15 1:34 AM, David Bremner wrote: > Unfortunately we did not receive any feedback from Mac users in the > meantime. It would be nice to know that your patch won't break the > existing macports and brew packages. I suppose that those work > because they install the libraries into a well know

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread Tomi Ollila
On Thu, Feb 26 2015, "J. Lewis Muir" wrote: > On 2/25/15 1:34 AM, David Bremner wrote: >> Unfortunately we did not receive any feedback from Mac users in the >> meantime. It would be nice to know that your patch won't break the >> existing macports and brew packages. I suppose that those work >>

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-26 Thread J. Lewis Muir
On 2/25/15 1:34 AM, David Bremner wrote: > Unfortunately we did not receive any feedback from Mac users in the > meantime. It would be nice to know that your patch won't break the > existing macports and brew packages. I suppose that those work > because they install the libraries into a well know

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-25 Thread David Bremner
"J. Lewis Muir" writes: > The install_name of libnotmuch.dylib on Mac OS X is what is written > into a program that links against it. If it is just the name of the > shared library file, as opposed to the full path, the program won't be > able to find it when it runs and will abort. Instead, th

Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2015-02-24 Thread David Bremner
"J. Lewis Muir" writes: > The install_name of libnotmuch.dylib on Mac OS X is what is written > into a program that links against it. If it is just the name of the > shared library file, as opposed to the full path, the program won't be > able to find it when it runs and will abort. Instead, th

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2014-08-31 Thread J. Lewis Muir
The install_name of libnotmuch.dylib on Mac OS X is what is written into a program that links against it. If it is just the name of the shared library file, as opposed to the full path, the program won't be able to find it when it runs and will abort. Instead, the install_name should be the full

[PATCH] lib: make notmuch shared library install_name be full path on Mac OS X

2014-08-31 Thread J. Lewis Muir
The install_name of libnotmuch.dylib on Mac OS X is what is written into a program that links against it. If it is just the name of the shared library file, as opposed to the full path, the program won't be able to find it when it runs and will abort. Instead, the install_name should be the full