Ralph Seichter writes:
> * David Bremner:
>
>> I did have to revert one unrelated whitespace change.
>
> I knew I might run afoul of that the minute I read "Indent is 4 spaces
> with mixed tab/spaces and a tab width of 8" in the code style notes. ;-)
>
> In my experience, it is error-prone to mix
* David Bremner:
> I did have to revert one unrelated whitespace change.
I knew I might run afoul of that the minute I read "Indent is 4 spaces
with mixed tab/spaces and a tab width of 8" in the code style notes. ;-)
In my experience, it is error-prone to mix tabs and spaces. Perhaps it
would be
Ralph Seichter writes:
> Fixed: If the output file for a dump was non-writeable, gzclose_w()
> was called twice on the output file handle, resulting in SIGABRT.
LGTM, although I did have to revert one unrelated whitespace change.
I'll push that later if no-one objects.
d
__
David Bremner writes:
> Ralph Seichter writes:
>
>> Fixed: If the output file for a dump was non-writeable, gzclose_w()
>> was called twice on the output file handle, resulting in SIGABRT.
>
> LGTM, although I did have to revert one unrelated whitespace change.
>
> I'll push that later if no-one
Fixed: If the output file for a dump was non-writeable, gzclose_w()
was called twice on the output file handle, resulting in SIGABRT.
---
notmuch-dump.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 505c1469..ca73d003 100644
--- a
This is version 2 of the patch, sorry for that. I had sent an older
version by mistake.
-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Fixed: If the output file for a dump was non-writeable, gzclose_w()
was called twice on the output file handle, resulting in SIGABRT.
---
notmuch-dump.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 505c1469..78282661 100644
--- a/no
