[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
On 2010-04-22, Sebastian Spaeth wrote: > From: Jesse Rosenthal This patch must have slipped in the patch series of the 6 other patches (which are all correct). Please ignore it. Note to myself, never do "git send-email 00*" Sebastian
[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
From: Jesse Rosenthal(Embarassing -- this should be the last fix.) Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an optional `buffer-name' argument to notmuch show. This version supersedes V1--3 of this patch. It is rebased on HEAD, ensures that the buffer names are unique, and that the `notmuch-show' command can still be used interactively (fixing embarassing bugs in V2 and V3 which prevented that) Signed-off-by: Jesse Rosenthal --- emacs/notmuch.el | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 439303a..4b93d8e 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -1178,7 +1178,7 @@ All currently available key bindings: (lambda() (hl-line-mode 1) )) -(defun notmuch-show (thread-id parent-buffer query-context) +(defun notmuch-show (thread-id parent-buffer query-context buffer-name) "Run \"notmuch show\" with the given thread ID and display results. The optional PARENT-BUFFER is the notmuch-search buffer from @@ -1186,9 +1186,14 @@ which this notmuch-show command was executed, (so that the next thread from that buffer can be show when done with this one). The optional QUERY-CONTEXT is a notmuch search term. Only messages from the thread -matching this search term are shown if non-nil. " +matching this search term are shown if non-nil. + +The optional BUFFER-NAME provides the neame of the buffer in which the message thread is shown. If it is nil (which occurs when the command is called interactively) the argument to the function is used. " (interactive "sNotmuch show: ") - (let ((buffer (get-buffer-create (concat "*notmuch-show-" thread-id "*" + (when (null buffer-name) +(setq buffer-name (concat "*notmuch-" thread-id "*"))) + (let* ((thread-buffer-name (generate-new-buffer-name buffer-name)) +(buffer (get-buffer-create thread-buffer-name))) (switch-to-buffer buffer) (notmuch-show-mode) (set (make-local-variable 'notmuch-show-parent-buffer) parent-buffer) @@ -1383,9 +1388,19 @@ Complete list of currently available key bindings: (defun notmuch-search-show-thread () "Display the currently selected thread." (interactive) - (let ((thread-id (notmuch-search-find-thread-id))) + (let ((thread-id (notmuch-search-find-thread-id)) + (subject (notmuch-search-find-subject)) + buffer-name) +(when (string-match "^[ \t]*$" subject) + (setq subject "[No Subject]")) +(setq buffer-name (concat "*" + (truncate-string-to-width subject 32 nil nil t) + "*")) (if (> (length thread-id) 0) - (notmuch-show thread-id (current-buffer) notmuch-search-query-string) + (notmuch-show thread-id + (current-buffer) + notmuch-search-query-string + buffer-name) (error "End of search results" (defun notmuch-search-reply-to-thread () -- 1.6.3.3
[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
From: Jesse Rosenthal jrosent...@jhu.edu (Embarassing -- this should be the last fix.) Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an optional `buffer-name' argument to notmuch show. This version supersedes V1--3 of this patch. It is rebased on HEAD, ensures that the buffer names are unique, and that the `notmuch-show' command can still be used interactively (fixing embarassing bugs in V2 and V3 which prevented that) Signed-off-by: Jesse Rosenthal jrosent...@jhu.edu --- emacs/notmuch.el | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 439303a..4b93d8e 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -1178,7 +1178,7 @@ All currently available key bindings: (lambda() (hl-line-mode 1) )) -(defun notmuch-show (thread-id optional parent-buffer query-context) +(defun notmuch-show (thread-id optional parent-buffer query-context buffer-name) Run \notmuch show\ with the given thread ID and display results. The optional PARENT-BUFFER is the notmuch-search buffer from @@ -1186,9 +1186,14 @@ which this notmuch-show command was executed, (so that the next thread from that buffer can be show when done with this one). The optional QUERY-CONTEXT is a notmuch search term. Only messages from the thread -matching this search term are shown if non-nil. +matching this search term are shown if non-nil. + +The optional BUFFER-NAME provides the neame of the buffer in which the message thread is shown. If it is nil (which occurs when the command is called interactively) the argument to the function is used. (interactive sNotmuch show: ) - (let ((buffer (get-buffer-create (concat *notmuch-show- thread-id * + (when (null buffer-name) +(setq buffer-name (concat *notmuch- thread-id *))) + (let* ((thread-buffer-name (generate-new-buffer-name buffer-name)) +(buffer (get-buffer-create thread-buffer-name))) (switch-to-buffer buffer) (notmuch-show-mode) (set (make-local-variable 'notmuch-show-parent-buffer) parent-buffer) @@ -1383,9 +1388,19 @@ Complete list of currently available key bindings: (defun notmuch-search-show-thread () Display the currently selected thread. (interactive) - (let ((thread-id (notmuch-search-find-thread-id))) + (let ((thread-id (notmuch-search-find-thread-id)) + (subject (notmuch-search-find-subject)) + buffer-name) +(when (string-match ^[ \t]*$ subject) + (setq subject [No Subject])) +(setq buffer-name (concat * + (truncate-string-to-width subject 32 nil nil t) + *)) (if ( (length thread-id) 0) - (notmuch-show thread-id (current-buffer) notmuch-search-query-string) + (notmuch-show thread-id + (current-buffer) + notmuch-search-query-string + buffer-name) (error End of search results (defun notmuch-search-reply-to-thread () -- 1.6.3.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
On 2010-04-22, Sebastian Spaeth wrote: From: Jesse Rosenthal jrosent...@jhu.edu This patch must have slipped in the patch series of the 6 other patches (which are all correct). Please ignore it. Note to myself, never do git send-email 00* Sebastian ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
From: Jesse RosenthalChange the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an optional `buffer-name' argument to notmuch show. This version supersedes V1--3 of this patch. It ensures that the buffer names are unique, and that the `notmuch-show' command can still be used interactively (fixing embarassing bugs in V2 and V3 which prevented that) Signed-off-by: Jesse Rosenthal Signed-off-by: Sebastian Spaeth --- emacs/notmuch-show.el | 11 --- emacs/notmuch.el | 14 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index cc1f905..ed95afb 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -959,7 +959,7 @@ All currently available key bindings: (lambda() (hl-line-mode 1) )) -(defun notmuch-show (thread-id parent-buffer query-context) +(defun notmuch-show (thread-id parent-buffer query-context buffer-name) "Run \"notmuch show\" with the given thread ID and display results. The optional PARENT-BUFFER is the notmuch-search buffer from @@ -967,9 +967,14 @@ which this notmuch-show command was executed, (so that the next thread from that buffer can be show when done with this one). The optional QUERY-CONTEXT is a notmuch search term. Only messages from the thread -matching this search term are shown if non-nil. " +matching this search term are shown if non-nil. + +The optional BUFFER-NAME provides the neame of the buffer in which the message thread is shown. If it is nil (which occurs when the command is called interactively) the argument to the function is used. " (interactive "sNotmuch show: ") - (let ((buffer (get-buffer-create (concat "*notmuch-show-" thread-id "*" + (when (null buffer-name) +(setq buffer-name (concat "*notmuch-" thread-id "*"))) + (let* ((thread-buffer-name (generate-new-buffer-name buffer-name)) +(buffer (get-buffer-create thread-buffer-name))) (switch-to-buffer buffer) (notmuch-show-mode) (set (make-local-variable 'notmuch-show-parent-buffer) parent-buffer) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 5e479d6..ca0b6e0 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -404,9 +404,19 @@ Complete list of currently available key bindings: (defun notmuch-search-show-thread () "Display the currently selected thread." (interactive) - (let ((thread-id (notmuch-search-find-thread-id))) + (let ((thread-id (notmuch-search-find-thread-id)) + (subject (notmuch-search-find-subject)) + buffer-name) +(when (string-match "^[ \t]*$" subject) + (setq subject "[No Subject]")) +(setq buffer-name (concat "*" + (truncate-string-to-width subject 32 nil nil t) + "*")) (if (> (length thread-id) 0) - (notmuch-show thread-id (current-buffer) notmuch-search-query-string) + (notmuch-show thread-id + (current-buffer) + notmuch-search-query-string + buffer-name) (error "End of search results" (defun notmuch-search-reply-to-thread () -- 1.6.3.3
[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)
From: Jesse Rosenthal jrosent...@jhu.edu Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to scroll through numerous open buffers. Note that this patch adds an optional `buffer-name' argument to notmuch show. This version supersedes V1--3 of this patch. It ensures that the buffer names are unique, and that the `notmuch-show' command can still be used interactively (fixing embarassing bugs in V2 and V3 which prevented that) Signed-off-by: Jesse Rosenthal jrosent...@jhu.edu Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- emacs/notmuch-show.el | 11 --- emacs/notmuch.el | 14 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index cc1f905..ed95afb 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -959,7 +959,7 @@ All currently available key bindings: (lambda() (hl-line-mode 1) )) -(defun notmuch-show (thread-id optional parent-buffer query-context) +(defun notmuch-show (thread-id optional parent-buffer query-context buffer-name) Run \notmuch show\ with the given thread ID and display results. The optional PARENT-BUFFER is the notmuch-search buffer from @@ -967,9 +967,14 @@ which this notmuch-show command was executed, (so that the next thread from that buffer can be show when done with this one). The optional QUERY-CONTEXT is a notmuch search term. Only messages from the thread -matching this search term are shown if non-nil. +matching this search term are shown if non-nil. + +The optional BUFFER-NAME provides the neame of the buffer in which the message thread is shown. If it is nil (which occurs when the command is called interactively) the argument to the function is used. (interactive sNotmuch show: ) - (let ((buffer (get-buffer-create (concat *notmuch-show- thread-id * + (when (null buffer-name) +(setq buffer-name (concat *notmuch- thread-id *))) + (let* ((thread-buffer-name (generate-new-buffer-name buffer-name)) +(buffer (get-buffer-create thread-buffer-name))) (switch-to-buffer buffer) (notmuch-show-mode) (set (make-local-variable 'notmuch-show-parent-buffer) parent-buffer) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 5e479d6..ca0b6e0 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -404,9 +404,19 @@ Complete list of currently available key bindings: (defun notmuch-search-show-thread () Display the currently selected thread. (interactive) - (let ((thread-id (notmuch-search-find-thread-id))) + (let ((thread-id (notmuch-search-find-thread-id)) + (subject (notmuch-search-find-subject)) + buffer-name) +(when (string-match ^[ \t]*$ subject) + (setq subject [No Subject])) +(setq buffer-name (concat * + (truncate-string-to-width subject 32 nil nil t) + *)) (if ( (length thread-id) 0) - (notmuch-show thread-id (current-buffer) notmuch-search-query-string) + (notmuch-show thread-id + (current-buffer) + notmuch-search-query-string + buffer-name) (error End of search results (defun notmuch-search-reply-to-thread () -- 1.6.3.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch