Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-02 Thread David Bremner
Ruben Pollan writes: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) yields key, value pairs pushed this version to master. Thanks for your contribution. d

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-02 Thread Ruben Pollan
Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) yields key, value pairs --- bindings/python/docs/source/message.rst | 4 ++ bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 80

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-02 Thread meskio
Quoting David Bremner (2018-05-02 02:08:26) > Ruben Pollan writes: > > > Message.get_property (prop) returns a string with the value of the property > > and > > Message.get_properties (prop, exact=False) yields key, value pairs > > --- > >

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-01 Thread David Bremner
Ruben Pollan writes: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) yields key, value pairs > --- > bindings/python/docs/source/message.rst | 4 ++ > bindings/python/notmuch/globals.py

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-01 Thread Ruben Pollan
Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) yields key, value pairs --- bindings/python/docs/source/message.rst | 4 ++ bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 80

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-01 Thread meskio
Quoting David Bremner (2018-05-01 15:06:38) > running the test below, I get > > Traceback (most recent call last): > File "", line 4, in > File > "/home/bremner/software/upstream/notmuch/bindings/python/notmuch/message.py", > line 480, in get_property > value = c_char_p("") >

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-05-01 Thread David Bremner
Ruben Pollan writes: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) yields key, value pairs > --- > bindings/python/docs/source/message.rst | 4 ++ > bindings/python/notmuch/globals.py

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-04-27 Thread Ruben Pollan
Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) yields key, value pairs --- bindings/python/docs/source/message.rst | 4 ++ bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 80

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2018-04-27 Thread meskio
Quoting David Bremner (2017-12-23 16:59:51) > Ruben Pollan writes: > > + > > +def get_properties(self, prop="", exact=False): > > As far as I understand, you also need to update docs/source/message.rst > so that your new methods are documented in the sphinx docs. > >

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-12-23 Thread David Bremner
Ruben Pollan writes: > + > +def get_properties(self, prop="", exact=False): As far as I understand, you also need to update docs/source/message.rst so that your new methods are documented in the sphinx docs. > +""" Get the properties for *message*, returning >

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-30 Thread Daniel Kahn Gillmor
On Thu 2017-11-30 09:44:19 -0400, David Bremner wrote: > Floris Bruynooghe writes: > >> This also has the binary question problem, is this returned as bytes or >> as str? Current Python bindings seem to go for .decode('utf-8', >> errors='ignore') afaik which is somewhat lossy. >>

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-30 Thread David Bremner
Floris Bruynooghe writes: > Daniel Kahn Gillmor writes: > > This also has the binary question problem, is this returned as bytes or > as str? Current Python bindings seem to go for .decode('utf-8', > errors='ignore') afaik which is somewhat lossy. >

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-29 Thread Floris Bruynooghe
Daniel Kahn Gillmor writes: > On Tue 2017-11-28 23:46:11 +0100, Ruben Pollan wrote: >> Message.get_property (prop) returns a string with the value of the property >> and >> Message.get_properties (prop, exact=False) returns a list [(key, value)] > > This looks like a

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-29 Thread Ruben Pollan
Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) returns a list [(key, value)] --- bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 81 +- 2 files

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-29 Thread meskio
Quoting Daniel Kahn Gillmor (2017-11-29 02:57:24) > On Tue 2017-11-28 23:46:11 +0100, Ruben Pollan wrote: > > Message.get_property (prop) returns a string with the value of the property > > and > > Message.get_properties (prop, exact=False) returns a list [(key, value)] > > This looks like a

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-28 Thread Daniel Kahn Gillmor
On Tue 2017-11-28 23:46:11 +0100, Ruben Pollan wrote: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) returns a list [(key, value)] This looks like a sensible approach to me. I'd be curious to hear what others

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-28 Thread meskio
Quoting Daniel Kahn Gillmor (2017-11-17 10:03:09) > On Wed 2017-11-15 23:29:54 +0100, Ruben Pollan wrote: > > Message.get_property (prop) returns a string with the value of the property. > > Upon review, this is actually insufficient for making robust use of the > session-key series :( > > In

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

2017-11-28 Thread Ruben Pollan
Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) returns a list [(key, value)] --- bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 78 +- 2 files