Re: [PATCH] python-cffi: enable out-of-tree builds

[Daniel Kahn Gillmor]

On Thu 2020-05-21 21:03:59 -0400, Daniel Kahn Gillmor wrote:
> This is a simple hack to enable out-of-tree builds, a concern raised
> by Tomi in id:m24kzjib9a@guru.guru-group.fi
>
> This change at least enables "make check" to complete without error,
> but I'm sure it could be improved.  I am not expert enough in
> setuptools to know how.

in id:87d06usa31@powell.devork.be, Floris said:

>> It probably is indeed the unfortunate case that copying the python
>> source is currently the easiest.  I had a quick look and it seemed like
>> one'd have to dig into the cffi setuptools support to make this work and
>> I'm not sure how successful that would be, but I admit I didn't feel
>> like trying.

So i've removed notmuch::needs-review -- sounds like this is currently
the way to go.

   --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] python-cffi: enable out-of-tree builds

[Daniel Kahn Gillmor]

This is a simple hack to enable out-of-tree builds, a concern raised
by Tomi in id:m24kzjib9a@guru.guru-group.fi

This change at least enables "make check" to complete without error,
but I'm sure it could be improved.  I am not expert enough in
setuptools to know how.

Signed-off-by: Daniel Kahn Gillmor 
---
 configure | 8 
 1 file changed, 8 insertions(+)

diff --git a/configure b/configure
index 37368bda..f0472e8e 100755
--- a/configure
+++ b/configure
@@ -70,6 +70,14 @@ if [ "$srcdir" != "." ]; then
 mkdir bindings/ruby
 cp -a "$srcdir"/bindings/ruby/*.[ch] bindings/ruby
 cp -a "$srcdir"/bindings/ruby/extconf.rb bindings/ruby
+
+# Use the same hack to replicate python-cffi source for
+# out-of-tree builds (again, not ideal).
+mkdir bindings/python-cffi
+cp -a "$srcdir"/bindings/python-cffi/tests \
+   "$srcdir"/bindings/python-cffi/notmuch2 \
+   "$srcdir"/bindings/python-cffi/setup.py \
+   bindings/python-cffi/
 fi
 
 # Set several defaults (optionally specified by the user in
-- 
2.26.2

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch