Re: [PATCH] python-cffi: read version from notmuch version file

2020-06-23 Thread Floris Bruynooghe
On Tue 23 Jun 2020 at 13:43 +0300, Frank LENORMAND wrote: > On Tue Jun 23 12:33:36 2020, David Bremner wrote: >> Frank LENORMAND writes: >> > For example, 0.30.1, with the first two numbers coming from the main >> > repository, and the last one acting as major for the bindings. >> > >> > 0.29.3

Re: [PATCH] python-cffi: read version from notmuch version file

2020-06-23 Thread David Bremner
Frank LENORMAND writes: > For example, 0.30.1, with the first two numbers coming from the main > repository, and the last one acting as major for the bindings. > > 0.29.3 → 0.29.1 > 0.30-rc2 → 0.30.1-rc2 > etc. > I'm mainly interested in supporting two use cases for notmuch: building everything

Re: [PATCH] python-cffi: read version from notmuch version file

2020-06-22 Thread Floris Bruynooghe
On Fri 19 Jun 2020 at 15:26 +0300, Frank LENORMAND wrote: > On Fri Jun 19 12:46:28 2020, Floris Bruynooghe wrote: >> This keeps it in sync with the main notmuch version which is less >> confusing to users. >> --- >> bindings/python-cffi/setup.py | 10 +- >> 1 file changed, 9

Re: [PATCH] python-cffi: read version from notmuch version file

2020-06-19 Thread Floris Bruynooghe
On Fri 19 Jun 2020 at 07:20 -0300, David Bremner wrote: > Floris Bruynooghe writes: > BTW I noticed something (setuptools?) translates "0.30~rc2" to > "0.30-rc2". I assume that is as intended, and there are some stricter > rules for python module versions. It should only affect pre-release >

Re: [PATCH] python-cffi: read version from notmuch version file

2020-06-19 Thread David Bremner
Floris Bruynooghe writes: > This keeps it in sync with the main notmuch version which is less > confusing to users. ah, that's much nicer than what I did for the old bindings. merged. BTW I noticed something (setuptools?) translates "0.30~rc2" to "0.30-rc2". I assume that is as intended, and

[PATCH] python-cffi: read version from notmuch version file

2020-06-19 Thread Floris Bruynooghe
This keeps it in sync with the main notmuch version which is less confusing to users. --- bindings/python-cffi/setup.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bindings/python-cffi/setup.py b/bindings/python-cffi/setup.py index 37918e3d..1effcfc6 100644 ---