On Tue, Apr 10 2012, Taylor Carpenter wrote:
> ---
what if instead of
> +my @filelist = `notmuch search --output=files $query`;
> +foreach(@filelist) {
there is:
open my $fh, '-|', qw/notmuch search --output=files/, $query;
while (<$fh>) {
...
}
unless (close $fh) {
#
Hi Taylor, thanks for your patch. It makes sense to me, and has the
beneficial side effect of avoiding a sed pass to do some poor men shell
escaping.
Before applying, however, can you please update it to:
- include a reasonable comment (as suggested by David)
- avoid patching the shebang line
On Tue, Apr 10 2012, Taylor Carpenter wrote:
---
what if instead of
+my @filelist = `notmuch search --output=files $query`;
+foreach(@filelist) {
there is:
open my $fh, '-|', qw/notmuch search --output=files/, $query;
while ($fh) {
...
}
unless (close $fh) {
#
Hi Taylor, and thanks for the patch.
In general for notmuch patches we prefer
- some kind of commit message beyond the one line summary explaining the
rationale for the change.
- not to have unrelated changes (/usr/bin/env perl) in the patch.
d
---
contrib/notmuch-mutt/notmuch-mutt | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/contrib/notmuch-mutt/notmuch-mutt
b/contrib/notmuch-mutt/notmuch-mutt
index 71206c3..dbe7f2d 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++
---
contrib/notmuch-mutt/notmuch-mutt | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/contrib/notmuch-mutt/notmuch-mutt
b/contrib/notmuch-mutt/notmuch-mutt
index 71206c3..dbe7f2d 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++
Hi Taylor, and thanks for the patch.
In general for notmuch patches we prefer
- some kind of commit message beyond the one line summary explaining the
rationale for the change.
- not to have unrelated changes (/usr/bin/env perl) in the patch.
d
