Re: [PATCH] test: add simple tests for online help

2011-11-27 Thread Jani Nikula
On Fri, 25 Nov 2011 13:36:26 -0500, David Bremner  wrote:
> I think Jani was just making fun of me when he suggested tests for
> notmuch --help, but I thought, why not.

Heh, I was only half joking - it is certainly good practice to create
tests for any bugs found and fixed. It's a bit embarrassing to have
--help segfault, but even more so to have it reappear in the future!
Good job.

Jani.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] test: add simple tests for online help

2011-11-26 Thread Jani Nikula
On Fri, 25 Nov 2011 13:36:26 -0500, David Bremner  wrote:
> I think Jani was just making fun of me when he suggested tests for
> notmuch --help, but I thought, why not.

Heh, I was only half joking - it is certainly good practice to create
tests for any bugs found and fixed. It's a bit embarrassing to have
--help segfault, but even more so to have it reappear in the future!
Good job.

Jani.


[PATCH] test: add simple tests for online help

2011-11-25 Thread David Bremner
From: David Bremner 

Nothing fancy, but we can at least detect segmentation faults.
---
I think Jani was just making fun of me when he suggested tests for notmuch 
--help, but I thought, why not.

 test/help-test|   12 
 test/notmuch-test |1 +
 2 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100755 test/help-test

diff --git a/test/help-test b/test/help-test
new file mode 100755
index 000..9f4b9c7
--- /dev/null
+++ b/test/help-test
@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+
+test_description="online help"
+. test-lib.sh
+
+test_expect_success 'notmuch --help' 'notmuch --help'
+test_expect_success 'notmuch --help tag' 'notmuch --help tag'
+test_expect_success 'notmuch help' 'notmuch help'
+test_expect_success 'notmuch help tag' 'notmuch help tag'
+test_expect_success 'notmuch --version' 'notmuch --version'
+
+test_done
diff --git a/test/notmuch-test b/test/notmuch-test
index adfd589..5aced5c 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -18,6 +18,7 @@ cd $(dirname "$0")

 TESTS="
   basic
+  help-test
   new
   count
   search
-- 
1.7.5.4



[PATCH] test: add simple tests for online help

2011-11-25 Thread David Bremner
From: David Bremner 

Nothing fancy, but we can at least detect segmentation faults.
---
I think Jani was just making fun of me when he suggested tests for notmuch 
--help, but I thought, why not.

 test/help-test|   12 
 test/notmuch-test |1 +
 2 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100755 test/help-test

diff --git a/test/help-test b/test/help-test
new file mode 100755
index 000..9f4b9c7
--- /dev/null
+++ b/test/help-test
@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+
+test_description="online help"
+. test-lib.sh
+
+test_expect_success 'notmuch --help' 'notmuch --help'
+test_expect_success 'notmuch --help tag' 'notmuch --help tag'
+test_expect_success 'notmuch help' 'notmuch help'
+test_expect_success 'notmuch help tag' 'notmuch help tag'
+test_expect_success 'notmuch --version' 'notmuch --version'
+
+test_done
diff --git a/test/notmuch-test b/test/notmuch-test
index adfd589..5aced5c 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -18,6 +18,7 @@ cd $(dirname "$0")
 
 TESTS="
   basic
+  help-test
   new
   count
   search
-- 
1.7.5.4

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch