[PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 07:37:13 -0400, David Bremner wrote: > On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > > > Running `domainname' instead seems to do the right thing though... > > > > I make no claims to

[PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Sat, 14 Jan 2012 08:16:30 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote: > > Full test coverage for getting, setting and removing options in > > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). > > > > --- > > + > > +# FIXME: Not the

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Mon, 16 Jan 2012 07:37:13 -0400, David Bremner wrote: > On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > > > Running `domainname' instead seems to do the right thing though... > > > > I make no claims to

[PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > Running `domainname' instead seems to do the right thing though... > I make no claims to have "correctly" configured this machine on my home network, but here it

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread David Bremner
On Mon, 16 Jan 2012 11:31:11 +0100, Pieter Praet wrote: > > Hmmm, `dnsdomainname' returns "(none)" here; Does it work for you? > > Running `domainname' instead seems to do the right thing though... > I make no claims to have "correctly" configured this machine on my home network, but here it

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-16 Thread Pieter Praet
On Sat, 14 Jan 2012 08:16:30 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote: > > Full test coverage for getting, setting and removing options in > > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). > > > > --- > > + > > +# FIXME: Not the

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
Full test coverage for getting, setting and removing options in notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). --- Please *do* take note of the FIXME in the last test! test/config | 88 + test/notmuch-test |1 +

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > > Should have come before commit 1df71b55 > > This doesn't seem like an especially helpful commit > message. Editorializing is ok, I guess, but maybe keep it below the > '---' ? >

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread David Bremner
On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote: > Full test coverage for getting, setting and removing options in > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). > > --- > + > +# FIXME: Not the most robust nor portable solution here... > +# Especially `hostname --do

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread David Bremner
On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet wrote: > Full test coverage for getting, setting and removing options in > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). > > --- > + > +# FIXME: Not the most robust nor portable solution here... > +# Especially `hostname --do

[PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
Full test coverage for getting, setting and removing options in notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config). --- Please *do* take note of the FIXME in the last test! test/config | 88 + test/notmuch-test |1 +

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-14 Thread Pieter Praet
On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner wrote: > On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > > Should have come before commit 1df71b55 > > This doesn't seem like an especially helpful commit > message. Editorializing is ok, I guess, but maybe keep it below the > '---' ? >

[PATCH] test: cli: getting/setting/removing config values

2012-01-12 Thread David Bremner
On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > Should have come before commit 1df71b55 This doesn't seem like an especially helpful commit message. Editorializing is ok, I guess, but maybe keep it below the '---' ? d

Re: [PATCH] test: cli: getting/setting/removing config values

2012-01-12 Thread David Bremner
On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet wrote: > Should have come before commit 1df71b55 This doesn't seem like an especially helpful commit message. Editorializing is ok, I guess, but maybe keep it below the '---' ? d ___ notmuch mailing list

[PATCH] test: cli: getting/setting/removing config values

2012-01-12 Thread Pieter Praet
Should have come before commit 1df71b55 --- test/config | 88 + test/notmuch-test |1 + 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755 in

[PATCH] test: cli: getting/setting/removing config values

2012-01-12 Thread Pieter Praet
Should have come before commit 1df71b55 --- test/config | 88 + test/notmuch-test |1 + 2 files changed, 89 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755 in