Re: [PATCH] test: increase cffi timeout

2022-08-16 Thread David Bremner
michaeljgruber+grubix+...@gmail.com writes:

> From: Michael J Gruber 
>
> By default, the test suite uses 2min for other tests and 5s for cffi
> tests. Sporadically, this leads to test failures caused by the timeout
> on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
> infrastructure during branch time).
>
> Increase the cffi timeout to the same 2m=120s.
>
> Signed-off-by: Michael J Gruber 
> ---
> It's the first time I encountered this on Fedora's infrastructure during
> a test build. In any case, having the timeouts similar may make sense in
> general, unless we typically run into them in normal (local) use.
>

Applied to release and master.

It is still not exactly consistent with the other tests, since the
remaining tests have a 2 minute timeout per test script T*.sh, not per
subtest. The python CFFI tests have timeouts for both.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH] test: increase cffi timeout

2022-08-15 Thread Tomi Ollila
On Sun, Aug 14 2022, michaeljgruber wrote:

> From: Michael J Gruber 
>
> By default, the test suite uses 2min for other tests and 5s for cffi
> tests. Sporadically, this leads to test failures caused by the timeout
> on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
> infrastructure during branch time).
>
> Increase the cffi timeout to the same 2m=120s.
>
> Signed-off-by: Michael J Gruber 
> ---
> It's the first time I encountered this on Fedora's infrastructure during
> a test build. In any case, having the timeouts similar may make sense in
> general, unless we typically run into them in normal (local) use.
>
>  bindings/python-cffi/tests/conftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/python-cffi/tests/conftest.py 
> b/bindings/python-cffi/tests/conftest.py
> index 6835fd30..fe90c787 100644
> --- a/bindings/python-cffi/tests/conftest.py
> +++ b/bindings/python-cffi/tests/conftest.py
> @@ -43,7 +43,7 @@ def notmuch(maildir):
>  env = os.environ.copy()
>  env['NOTMUCH_CONFIG'] = str(cfg_fname)
>  proc = subprocess.run(cmd,
> -  timeout=5,
> +  timeout=120,

LGTM.

Tomi

>env=env)
>  proc.check_returncode()
>  return run
> -- 
> 2.37.2.596.g72ccb331cf
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


[PATCH] test: increase cffi timeout

2022-08-14 Thread michaeljgruber+grubix+git
From: Michael J Gruber 

By default, the test suite uses 2min for other tests and 5s for cffi
tests. Sporadically, this leads to test failures caused by the timeout
on slower or loaded test infrastructure (as seen on ppc64le in Fedora's
infrastructure during branch time).

Increase the cffi timeout to the same 2m=120s.

Signed-off-by: Michael J Gruber 
---
It's the first time I encountered this on Fedora's infrastructure during
a test build. In any case, having the timeouts similar may make sense in
general, unless we typically run into them in normal (local) use.

 bindings/python-cffi/tests/conftest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bindings/python-cffi/tests/conftest.py 
b/bindings/python-cffi/tests/conftest.py
index 6835fd30..fe90c787 100644
--- a/bindings/python-cffi/tests/conftest.py
+++ b/bindings/python-cffi/tests/conftest.py
@@ -43,7 +43,7 @@ def notmuch(maildir):
 env = os.environ.copy()
 env['NOTMUCH_CONFIG'] = str(cfg_fname)
 proc = subprocess.run(cmd,
-  timeout=5,
+  timeout=120,
   env=env)
 proc.check_returncode()
 return run
-- 
2.37.2.596.g72ccb331cf

___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org