Re: [PATCH] use notmuch_database_open_verbose

2016-03-13 Thread David Bremner
Patrick Totzke writes: > As far as I understand the bindings, the returned message is not needed > because the return > value of `Database._open` (line 212) contains information about the type of > error that occurred. > This is passed on two lines below if the open-call

Re: [PATCH] use notmuch_database_open_verbose

2016-03-13 Thread Patrick Totzke
As far as I understand the bindings, the returned message is not needed because the return value of `Database._open` (line 212) contains information about the type of error that occurred. This is passed on two lines below if the open-call was unsuccessful. The docstrings for this method are not

Re: [PATCH] use notmuch_database_open_verbose

2016-03-12 Thread David Bremner
David Bremner writes: >> -"""notmuch_database_open""" >> -_open = nmlib.notmuch_database_open >> +"""notmuch_database_open_verbose""" >> +_open = nmlib.notmuch_database_open_verbose >> _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)] >>

Re: [PATCH] use notmuch_database_open_verbose

2016-03-12 Thread David Bremner
Patrick Totzke writes: > ... instead of the deprecated notmuch_database_open Perhaps it should be formally deprecated, but unlike several other functions, it isn't. > when opening the database in notmuch.database.Database.open. > This prevents the library to print

[PATCH] use notmuch_database_open_verbose

2016-03-12 Thread Patrick Totzke
... instead of the deprecated notmuch_database_open when opening the database in notmuch.database.Database.open. This prevents the library to print Xapian exceptions to stderr. --- bindings/python/notmuch/database.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git