[PATCH] vim: simplify build

2012-04-21 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 7:03 PM, Tomi Ollila wrote: > So, $(CURDIR) has 3 votes :D All right. Pushed :) -- Felipe Contreras

Re: [PATCH] vim: simplify build

2012-04-20 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 7:03 PM, Tomi Ollila tomi.oll...@iki.fi wrote: So, $(CURDIR) has 3 votes :D All right. Pushed :) -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] vim: simplify build

2012-04-18 Thread Tomi Ollila
On Wed, Apr 18 2012, Felipe Contreras wrote: > On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila wrote: >> On Wed, Apr 18 2012, David Bremner wrote: >> >>> Felipe Contreras writes: > If this is not an issue, then LGTM. I don't know, I have always used $(PWD), unless anybody else

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila wrote: > On Wed, Apr 18 2012, David Bremner wrote: > >> Felipe Contreras writes: If this is not an issue, then LGTM. >>> >>> I don't know, I have always used $(PWD), unless anybody else prefers >>> $(CURDIR), I'll push that. >> >> I think CURDIR

[PATCH] vim: simplify build

2012-04-18 Thread Tomi Ollila
On Wed, Apr 18 2012, David Bremner wrote: > Felipe Contreras writes: >>> If this is not an issue, then LGTM. >> >> I don't know, I have always used $(PWD), unless anybody else prefers >> $(CURDIR), I'll push that. > > I think CURDIR is better; if only because it is the standard (GNU) make > way

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 4:11 PM, Tomi Ollila wrote: > On Wed, Apr 18 2012, Felipe Contreras wrote: > >> There should be no functional changes, except that you don't need to >> make the directories before installing. >> >> Signed-off-by: Felipe Contreras >> --- > > Hmm, Where is $(PWD) make

[PATCH] vim: simplify build

2012-04-18 Thread Tomi Ollila
On Wed, Apr 18 2012, Felipe Contreras wrote: > There should be no functional changes, except that you don't need to > make the directories before installing. > > Signed-off-by: Felipe Contreras > --- Hmm, Where is $(PWD) make variable documented; I found only $(CURDIR) anyway, te following

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
There should be no functional changes, except that you don't need to make the directories before installing. Signed-off-by: Felipe Contreras --- vim/Makefile | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/vim/Makefile b/vim/Makefile index

[PATCH] vim: simplify build

2012-04-18 Thread David Bremner
Felipe Contreras writes: >> If this is not an issue, then LGTM. > > I don't know, I have always used $(PWD), unless anybody else prefers > $(CURDIR), I'll push that. I think CURDIR is better; if only because it is the standard (GNU) make way of doing things [1]. I'm not sure if there is a

[PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
There should be no functional changes, except that you don't need to make the directories before installing. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/Makefile | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/vim/Makefile

Re: [PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 4:11 PM, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Apr 18 2012, Felipe Contreras felipe.contre...@gmail.com wrote: There should be no functional changes, except that you don't need to make the directories before installing. Signed-off-by: Felipe Contreras

Re: [PATCH] vim: simplify build

2012-04-18 Thread David Bremner
Felipe Contreras felipe.contre...@gmail.com writes: If this is not an issue, then LGTM. I don't know, I have always used $(PWD), unless anybody else prefers $(CURDIR), I'll push that. I think CURDIR is better; if only because it is the standard (GNU) make way of doing things [1]. I'm not

Re: [PATCH] vim: simplify build

2012-04-18 Thread Tomi Ollila
On Wed, Apr 18 2012, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: If this is not an issue, then LGTM. I don't know, I have always used $(PWD), unless anybody else prefers $(CURDIR), I'll push that. I think CURDIR is better; if only because it

Re: [PATCH] vim: simplify build

2012-04-18 Thread Felipe Contreras
On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Apr 18 2012, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: If this is not an issue, then LGTM. I don't know, I have always used $(PWD), unless anybody else prefers

Re: [PATCH] vim: simplify build

2012-04-18 Thread Tomi Ollila
On Wed, Apr 18 2012, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Apr 18, 2012 at 6:40 PM, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Apr 18 2012, David Bremner da...@tethera.net wrote: Felipe Contreras felipe.contre...@gmail.com writes: If this is not an issue, then LGTM.