Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
On Tue, Apr 02 2019, Örjan Ekeberg wrote: > Tomi Ollila writes: >> two things >> >> - I wonder whether we could drop (defun notmuch-message-mark-replied ()...) >> - why is it needed for backward compatibility ? > > Yes, it would be cleaner to simply remove it. My thought was that there > is a slight risk that someone is explicitly using or manipulating this > function in some personal code. This is probably very unlikely, so I am > more than happy to drop it. I think dropping is safe. >> - A test of a few would be nice to see how this behaves -- and we can see >> that this still works e.g. on emacs 24... > > Indeed. I did consider this, but since I am not at all familiar with > how to write such tests, I did not proceed with this. No-one is, but with little investigation, and then (ab)using some of the current emacs tests as base for a new test should be doable. > > /Örjan Tomi ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
Tomi Ollila writes: > two things > > - I wonder whether we could drop (defun notmuch-message-mark-replied ()...) > - why is it needed for backward compatibility ? Yes, it would be cleaner to simply remove it. My thought was that there is a slight risk that someone is explicitly using or manipulating this function in some personal code. This is probably very unlikely, so I am more than happy to drop it. > > - A test of a few would be nice to see how this behaves -- and we can see > that this still works e.g. on emacs 24... Indeed. I did consider this, but since I am not at all familiar with how to write such tests, I did not proceed with this. /Örjan ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
On Sat, Mar 30 2019, Örjan Ekeberg wrote: > These patches implement a message-send-hook which uses a buffer-local variable > to tag replied and forwarded messages. > > The first patch replaces the current heuristic hook for detecting reply > messages with an explicit setting when the reply is composed. > > The second patch adds the corresponding mechanism for forwarded messages. > This patch is on top of a previously submitted patch (for adding a References > header), and will not apply cleanly without that. I could comprehend most of the content -- cl loop is something that would require more learning... but I believe it works... two things - I wonder whether we could drop (defun notmuch-message-mark-replied ()...) - why is it needed for backward compatibility ? - A test of a few would be nice to see how this behaves -- and we can see that this still works e.g. on emacs 24... Tomi > > Örjan Ekeberg (2): > emacs: Use a buffer-local variable to update tags when sending replies > emacs: Tag forwarded messages with +forwarded (customizable) > > emacs/notmuch-message.el | 34 -- > emacs/notmuch-mua.el | 26 +++--- > 2 files changed, 51 insertions(+), 9 deletions(-) > > -- > 2.20.1 > > ___ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
On Sat 2019-03-30 22:48:19 +0100, Örjan Ekeberg wrote: > These patches implement a message-send-hook which uses a buffer-local variable > to tag replied and forwarded messages. > > The first patch replaces the current heuristic hook for detecting reply > messages with an explicit setting when the reply is composed. > > The second patch adds the corresponding mechanism for forwarded messages. > This patch is on top of a previously submitted patch (for adding a References > header), and will not apply cleanly without that. My elisp skills aren't sufficient for me to offer any substantive review for this series, but i like the proposal, and i think it looks like a useful feature addition to the notmuch-emacs MUA. Thanks for proposing it, Örjan! --dkg ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
These patches implement a message-send-hook which uses a buffer-local variable to tag replied and forwarded messages. The first patch replaces the current heuristic hook for detecting reply messages with an explicit setting when the reply is composed. The second patch adds the corresponding mechanism for forwarded messages. This patch is on top of a previously submitted patch (for adding a References header), and will not apply cleanly without that. Örjan Ekeberg (2): emacs: Use a buffer-local variable to update tags when sending replies emacs: Tag forwarded messages with +forwarded (customizable) emacs/notmuch-message.el | 34 -- emacs/notmuch-mua.el | 26 +++--- 2 files changed, 51 insertions(+), 9 deletions(-) -- 2.20.1 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
