[PATCH 0/3] Configuration file option to exclude files/directories

[David Edmondson]

On Thu, 08 Dec 2011 11:05:50 +0200, Tomi Ollila  wrote:
> On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner  
> wrote:
> > On Wed, 14 Sep 2011 00:32:01 +0300, tomi.ollila at iki.fi wrote:
> > > This patch set adds a configuration option 'database.exclude'; a list of
> > > files/directories to be excluded when doing 'notmuch new' operation.
> > 
> > Hi All;
> > 
> > I could see idea of excluding spam and trash folders from indexing being
> > useful, but this has been sitting in the list for a few months without
> > comment. Does that mean no-one but Tomi thinks the functionality is
> > interesting? Or it just slipped by?
> 
> Well, basically due to my comments in 
> id:"1315949524-4948-1-git-send-email-tomi.ollila at iki.fi" (and so far little
> interest to this patch series) I have 'drafts' and 'spam' directories
> elsewhere. 
> 
> If there is renewed interests with real use cases I'm interested to make
> this work more complete (now that there is change to get patches in ;) 
> -- and then move my drafts and spam under database.path too.

I'd be interested in these changes (I'd like to ignore .git). It would
help if a test case or two was include.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 

[PATCH 0/3] Configuration file option to exclude files/directories

[Pieter Praet]

On Thu, 08 Dec 2011 11:05:50 +0200, Tomi Ollila  wrote:
> On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner  
> wrote:
> > On Wed, 14 Sep 2011 00:32:01 +0300, tomi.ollila at iki.fi wrote:
> > > This patch set adds a configuration option 'database.exclude'; a list of
> > > files/directories to be excluded when doing 'notmuch new' operation.
> > 
> > Hi All;
> > 
> > I could see idea of excluding spam and trash folders from indexing being
> > useful, but this has been sitting in the list for a few months without
> > comment. Does that mean no-one but Tomi thinks the functionality is
> > interesting? Or it just slipped by?
> 
> Well, basically due to my comments in 
> id:"1315949524-4948-1-git-send-email-tomi.ollila at iki.fi" (and so far little
> interest to this patch series) I have 'drafts' and 'spam' directories
> elsewhere. 
> 
> If there is renewed interests with real use cases I'm interested to make
> this work more complete (now that there is change to get patches in ;) 
> -- and then move my drafts and spam under database.path too.
> 

Please do!  The desire to be able to exclude certain files/folders has been
expressed many times in the past [1], and once again a mere 2 days ago [2].

I'm currently kicking myself for somehow having missed this thread...

Many thanks in advance!


> I'll mark the current patches as 'notmuch::wip' for the time being.
> 
> > 
> > d
> > 
> 
> Tomi
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Peace

-- 
Pieter

[1] id:"AANLkTikddX=fYiDmnN2Jx3ERcJndw=80+5_07=M45MQ=@mail.gmail.com"
[2] id:"20120122113212.GA7084 at X200"

Re: [PATCH 0/3] Configuration file option to exclude files/directories

[David Edmondson]

On Thu, 08 Dec 2011 11:05:50 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
 On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner da...@tethera.net wrote:
  On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote:
   This patch set adds a configuration option 'database.exclude'; a list of
   files/directories to be excluded when doing 'notmuch new' operation.
  
  Hi All;
  
  I could see idea of excluding spam and trash folders from indexing being
  useful, but this has been sitting in the list for a few months without
  comment. Does that mean no-one but Tomi thinks the functionality is
  interesting? Or it just slipped by?
 
 Well, basically due to my comments in 
 id:1315949524-4948-1-git-send-email-tomi.oll...@iki.fi (and so far little
 interest to this patch series) I have 'drafts' and 'spam' directories
 elsewhere. 
 
 If there is renewed interests with real use cases I'm interested to make
 this work more complete (now that there is change to get patches in ;) 
 -- and then move my drafts and spam under database.path too.

I'd be interested in these changes (I'd like to ignore .git). It would
help if a test case or two was include.


pgpdemvhKFftq.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 0/3] Configuration file option to exclude files/directories

[Tomi Ollila]

On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner  wrote:
> On Wed, 14 Sep 2011 00:32:01 +0300, tomi.ollila at iki.fi wrote:
> > This patch set adds a configuration option 'database.exclude'; a list of
> > files/directories to be excluded when doing 'notmuch new' operation.
> 
> Hi All;
> 
> I could see idea of excluding spam and trash folders from indexing being
> useful, but this has been sitting in the list for a few months without
> comment. Does that mean no-one but Tomi thinks the functionality is
> interesting? Or it just slipped by?

Well, basically due to my comments in 
id:"1315949524-4948-1-git-send-email-tomi.ollila at iki.fi" (and so far little
interest to this patch series) I have 'drafts' and 'spam' directories
elsewhere. 

If there is renewed interests with real use cases I'm interested to make
this work more complete (now that there is change to get patches in ;) 
-- and then move my drafts and spam under database.path too.

I'll mark the current patches as 'notmuch::wip' for the time being.

> 
> d
> 

Tomi

Re: [PATCH 0/3] Configuration file option to exclude files/directories

[Tomi Ollila]

On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner da...@tethera.net wrote:
 On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote:
  This patch set adds a configuration option 'database.exclude'; a list of
  files/directories to be excluded when doing 'notmuch new' operation.
 
 Hi All;
 
 I could see idea of excluding spam and trash folders from indexing being
 useful, but this has been sitting in the list for a few months without
 comment. Does that mean no-one but Tomi thinks the functionality is
 interesting? Or it just slipped by?

Well, basically due to my comments in 
id:1315949524-4948-1-git-send-email-tomi.oll...@iki.fi (and so far little
interest to this patch series) I have 'drafts' and 'spam' directories
elsewhere. 

If there is renewed interests with real use cases I'm interested to make
this work more complete (now that there is change to get patches in ;) 
-- and then move my drafts and spam under database.path too.

I'll mark the current patches as 'notmuch::wip' for the time being.

 
 d
 

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 0/3] Configuration file option to exclude files/directories

[David Bremner]

On Wed, 14 Sep 2011 00:32:01 +0300, tomi.ollila at iki.fi wrote:
> This patch set adds a configuration option 'database.exclude'; a list of
> files/directories to be excluded when doing 'notmuch new' operation.

Hi All;

I could see idea of excluding spam and trash folders from indexing being
useful, but this has been sitting in the list for a few months without
comment. Does that mean no-one but Tomi thinks the functionality is
interesting? Or it just slipped by?

d

[PATCH 0/3] Configuration file option to exclude files/directories

[Tom Prince]

On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner  wrote:
> I could see idea of excluding spam and trash folders from indexing being
> useful, but this has been sitting in the list for a few months without
> comment. Does that mean no-one but Tomi thinks the functionality is
> interesting? Or it just slipped by?

A while a go, I had hacked the code to add .git to the list of excluded
dirctories, and I have since just moved .git under .notmuch. I think
this ability would be useful.

  Tom

Re: [PATCH 0/3] Configuration file option to exclude files/directories

[David Bremner]

On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote:
 This patch set adds a configuration option 'database.exclude'; a list of
 files/directories to be excluded when doing 'notmuch new' operation.

Hi All;

I could see idea of excluding spam and trash folders from indexing being
useful, but this has been sitting in the list for a few months without
comment. Does that mean no-one but Tomi thinks the functionality is
interesting? Or it just slipped by?

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/3] Configuration file option to exclude files/directories

[Tom Prince]

On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner da...@tethera.net wrote:
 I could see idea of excluding spam and trash folders from indexing being
 useful, but this has been sitting in the list for a few months without
 comment. Does that mean no-one but Tomi thinks the functionality is
 interesting? Or it just slipped by?

A while a go, I had hacked the code to add .git to the list of excluded
dirctories, and I have since just moved .git under .notmuch. I think
this ability would be useful.

  Tom
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 0/3] Configuration file option to exclude files/directories

[tomi.oll...@iki.fi]

This patch set adds a configuration option 'database.exclude'; a list of
files/directories to be excluded when doing 'notmuch new' operation.

Notes:

1) Currently the comments for newly created configuration file are not
updated, so for not this is 'undocumented feature'. Should there be an
empty configuration line as a placeholder ... ?

2) Whenever some already existing directory is added to the exclude list
and the parent directory timestamp has not changed, notmuch new will not
notice the directory has gone (as it still is there), user needs to 'touch'
the parent directory before next 'notmuch new' no make notmuch notice.

3) count_files() function is not touched. The functionality there has fallen
behind of add_files_recursive (maildir+tmp check and following symlinks).
The question there should it be updated, or attempted to merge with
add_files (as the comment says). count_files() is only called at the beginning
when database is not yet initialised.

Tomi

 notmuch-client.h |3 ++
 notmuch-config.c |   89 +++--
 notmuch-new.c|   22 -
 3 files changed, 88 insertions(+), 26 deletions(-)

[PATCH 0/3] Configuration file option to exclude files/directories

[tomi . ollila]

This patch set adds a configuration option 'database.exclude'; a list of
files/directories to be excluded when doing 'notmuch new' operation.

Notes:

1) Currently the comments for newly created configuration file are not
updated, so for not this is 'undocumented feature'. Should there be an
empty configuration line as a placeholder ... ?

2) Whenever some already existing directory is added to the exclude list
and the parent directory timestamp has not changed, notmuch new will not
notice the directory has gone (as it still is there), user needs to 'touch'
the parent directory before next 'notmuch new' no make notmuch notice.

3) count_files() function is not touched. The functionality there has fallen
behind of add_files_recursive (maildir+tmp check and following symlinks).
The question there should it be updated, or attempted to merge with
add_files (as the comment says). count_files() is only called at the beginning
when database is not yet initialised.

Tomi

 notmuch-client.h |3 ++
 notmuch-config.c |   89 +++--
 notmuch-new.c|   22 -
 3 files changed, 88 insertions(+), 26 deletions(-)

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch