[PATCH 0/4 v4] lib: Maildir flags synchronization fixes
> > I came across it, having been annoyed by the fact that notmuch broke my > > reading > > habits by marking messages (in the mutt sense) as seen, which I hadn't > > really > > seen yet in mutt. I tried out the patch; it applied and seems to work. What > > can > > I do to make it be applied? Other than giving it some attention. I must say > > that I have zero insight in the test framework, but if that's what's needed > > from me... > > The patches need to be reviewed for correctness and style. Typically any > non-trivial patch (or series) needs two reviews. You can see examples in > the archives of how this works. They are currently marked stale, which > is supposed to mean they no long apply. On the other hand, if they apply > for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ > for more information about patch tagging). I'm completely new to the notmuch core (but have been a user of the alot and emacs client for a while), and couldn't really say that they are completely fine. But they do apply (with some offset) to current master. They work, seem to do what they say--and the test runs OK. Thus I have now (after having been given access by David) removed notmuch::stale and added notmuch::needs-review on the following: 2011-09-15 Louis Rilling id:"1316039001-32602-4-git-send-email-l.rilling at av7.net" [PATCH 3/4] test: Adding non-maildir tags does not move message id:"1316039001-32602-5-git-send-email-l.rilling at av7.net" [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change And reviewers?
Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes
> > I came across it, having been annoyed by the fact that notmuch broke my > > reading > > habits by marking messages (in the mutt sense) as seen, which I hadn't > > really > > seen yet in mutt. I tried out the patch; it applied and seems to work. What > > can > > I do to make it be applied? Other than giving it some attention. I must say > > that I have zero insight in the test framework, but if that's what's needed > > from me... > > The patches need to be reviewed for correctness and style. Typically any > non-trivial patch (or series) needs two reviews. You can see examples in > the archives of how this works. They are currently marked stale, which > is supposed to mean they no long apply. On the other hand, if they apply > for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ > for more information about patch tagging). I'm completely new to the notmuch core (but have been a user of the alot and emacs client for a while), and couldn't really say that they are completely fine. But they do apply (with some offset) to current master. They work, seem to do what they say--and the test runs OK. Thus I have now (after having been given access by David) removed notmuch::stale and added notmuch::needs-review on the following: 2011-09-15 Louis Rilling id:"1316039001-32602-4-git-send-email-l.rill...@av7.net" [PATCH 3/4] test: Adding non-maildir tags does not move message id:"1316039001-32602-5-git-send-email-l.rill...@av7.net" [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change And reviewers? ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/4 v4] lib: Maildir flags synchronization fixes
On Thu, Sep 15, 2011 at 12:23:17AM +0200, Louis Rilling wrote: > The intent for the fourth patch (detailed in the commit log) is to allow mutt > users to keep using the "new" status, as long as notmuch can respect the > maildir specification. > > The third patch implements a test for the new desired behavior. From recent > discussions I decided to put it before the actual changes, but it certainly > can > move after if this is preferred. On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote: > I pushed the first two patches in this series; the second two need to be > updated for the new "broken test" framework, and reviewed. And old one... What came of this patch? I came across it, having been annoyed by the fact that notmuch broke my reading habits by marking messages (in the mutt sense) as seen, which I hadn't really seen yet in mutt. I tried out the patch; it applied and seems to work. What can I do to make it be applied? Other than giving it some attention. I must say that I have zero insight in the test framework, but if that's what's needed from me...
[PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Daniel writes: > On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote: >> I pushed the first two patches in this series; the second two need to be >> updated for the new "broken test" framework, and reviewed. > > And old one... What came of this patch? > > I came across it, having been annoyed by the fact that notmuch broke my > reading > habits by marking messages (in the mutt sense) as seen, which I hadn't really > seen yet in mutt. I tried out the patch; it applied and seems to work. What > can > I do to make it be applied? Other than giving it some attention. I must say > that I have zero insight in the test framework, but if that's what's needed > from me... The patches need to be reviewed for correctness and style. Typically any non-trivial patch (or series) needs two reviews. You can see examples in the archives of how this works. They are currently marked stale, which is supposed to mean they no long apply. On the other hand, if they apply for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ for more information about patch tagging). By the way, it seems like commit b88030b might be relevant. d
Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Daniel writes: > On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote: >> I pushed the first two patches in this series; the second two need to be >> updated for the new "broken test" framework, and reviewed. > > And old one... What came of this patch? > > I came across it, having been annoyed by the fact that notmuch broke my > reading > habits by marking messages (in the mutt sense) as seen, which I hadn't really > seen yet in mutt. I tried out the patch; it applied and seems to work. What > can > I do to make it be applied? Other than giving it some attention. I must say > that I have zero insight in the test framework, but if that's what's needed > from me... The patches need to be reviewed for correctness and style. Typically any non-trivial patch (or series) needs two reviews. You can see examples in the archives of how this works. They are currently marked stale, which is supposed to mean they no long apply. On the other hand, if they apply for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/ for more information about patch tagging). By the way, it seems like commit b88030b might be relevant. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes
On Thu, Sep 15, 2011 at 12:23:17AM +0200, Louis Rilling wrote: > The intent for the fourth patch (detailed in the commit log) is to allow mutt > users to keep using the "new" status, as long as notmuch can respect the > maildir specification. > > The third patch implements a test for the new desired behavior. From recent > discussions I decided to put it before the actual changes, but it certainly > can > move after if this is preferred. On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote: > I pushed the first two patches in this series; the second two need to be > updated for the new "broken test" framework, and reviewed. And old one... What came of this patch? I came across it, having been annoyed by the fact that notmuch broke my reading habits by marking messages (in the mutt sense) as seen, which I hadn't really seen yet in mutt. I tried out the patch; it applied and seems to work. What can I do to make it be applied? Other than giving it some attention. I must say that I have zero insight in the test framework, but if that's what's needed from me... ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Hello, Here is the updated series of fixes I have around maildir flags synchronization. The first two patches are just cleanups that can be applied independently. The intent for the fourth patch (detailed in the commit log) is to allow mutt users to keep using the "new" status, as long as notmuch can respect the maildir specification. The third patch implements a test for the new desired behavior. From recent discussions I decided to put it before the actual changes, but it certainly can move after if this is preferred. Changelog: * v4: - rebased on top of release 0.8 - included the test contributed by Michal Sojka * v3: Added patch to kill the last usage of C++ type bool * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Thanks, Louis Louis Rilling (3): lib: Kill last usage of C++ type bool tags_to_maildir_flags: Cleanup double assignement tags_to_maildir_flags: Don't rename if no flags change Michal Sojka (1): test: Adding non-maildir tags does not move message from new to cur lib/message.cc| 26 +- test/maildir-sync |6 ++ 2 files changed, 23 insertions(+), 9 deletions(-)
[PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Hello, Here is the updated series of fixes I have around maildir flags synchronization. The first two patches are just cleanups that can be applied independently. The intent for the fourth patch (detailed in the commit log) is to allow mutt users to keep using the "new" status, as long as notmuch can respect the maildir specification. The third patch implements a test for the new desired behavior. From recent discussions I decided to put it before the actual changes, but it certainly can move after if this is preferred. Changelog: * v4: - rebased on top of release 0.8 - included the test contributed by Michal Sojka * v3: Added patch to kill the last usage of C++ type bool * v2: Fix bool type as well as NULL returned despite having no errors (Austin Clements) Thanks, Louis Louis Rilling (3): lib: Kill last usage of C++ type bool tags_to_maildir_flags: Cleanup double assignement tags_to_maildir_flags: Don't rename if no flags change Michal Sojka (1): test: Adding non-maildir tags does not move message from new to cur lib/message.cc| 26 +- test/maildir-sync |6 ++ 2 files changed, 23 insertions(+), 9 deletions(-) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
