Re: [PATCH 04/27] emacs: don't fset keymaps

2020-11-11 Thread David Bremner
William Casarin writes: > Jonas Bernoulli writes: > > > I believe this makes sense. Looks like they were first introduced in > early versions of the code... > > Reviewed-by: William Casarin > Tested-by: William Casarin I have applied the first 4 patches. d

Re: [PATCH 04/27] emacs: don't fset keymaps

2020-11-11 Thread William Casarin
Jonas Bernoulli writes: > These keymaps are never invoked as commands > so the function definitions serve no purpose. > --- > emacs/notmuch-show.el | 1 - > emacs/notmuch-tree.el | 1 - > emacs/notmuch.el | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/emacs/notmuch-show.el

[PATCH 04/27] emacs: don't fset keymaps

2020-11-08 Thread Jonas Bernoulli
These keymaps are never invoked as commands so the function definitions serve no purpose. --- emacs/notmuch-show.el | 1 - emacs/notmuch-tree.el | 1 - emacs/notmuch.el | 1 - 3 files changed, 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index b08ceb97..ec22fd94