[PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-06 Thread David Bremner
Austin Clements writes: > Quoth David Bremner on Oct 05 at 10:56 am: >> Austin Clements writes: >> > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { >> > + t_end = db->metadata_keys_end ("thread_id_"); >> > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) >> > + ++tot

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-05 Thread David Bremner
Austin Clements writes: > Quoth David Bremner on Oct 05 at 10:56 am: >> Austin Clements writes: >> > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { >> > + t_end = db->metadata_keys_end ("thread_id_"); >> > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) >> > + ++tot

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-05 Thread Austin Clements
Quoth David Bremner on Oct 05 at 10:56 am: > Austin Clements writes: > > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > > + t_end = db->metadata_keys_end ("thread_id_"); > > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > > + ++total; > > +} > > It would b

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-05 Thread Austin Clements
Quoth David Bremner on Oct 05 at 10:56 am: > Austin Clements writes: > > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > > + t_end = db->metadata_keys_end ("thread_id_"); > > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > > + ++total; > > +} > > It would b

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-05 Thread David Bremner
Austin Clements writes: > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > + t_end = db->metadata_keys_end ("thread_id_"); > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > + ++total; > +} It would be nice to have the comment below, or something like i

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-05 Thread David Bremner
Austin Clements writes: > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > + t_end = db->metadata_keys_end ("thread_id_"); > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > + ++total; > +} It would be nice to have the comment below, or something like i

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-03 Thread Austin Clements
From: Austin Clements Somehow this is the first upgrade pass that actually does *any* error checking, so this also adds the bit of necessary infrastructure to handle that. --- lib/database.cc | 64 +++-- 1 file changed, 62 insertions(+), 2 dele

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

2014-10-03 Thread Austin Clements
From: Austin Clements Somehow this is the first upgrade pass that actually does *any* error checking, so this also adds the bit of necessary infrastructure to handle that. --- lib/database.cc | 64 +++-- 1 file changed, 62 insertions(+), 2 dele