[PATCH 09/11] cli/insert: add fail path to add_file_to_database

2014-09-26 Thread David Bremner
Jani Nikula writes: > + status = notmuch_message_tags_to_maildir_flags (message); ... > + /* > + * Note: Unfortunately a failed maildir flag sync might > + * already have renamed the file, in which case the cleanup > + * path will fail. > + */ I'd like to be more

Re: [PATCH 09/11] cli/insert: add fail path to add_file_to_database

2014-09-26 Thread David Bremner
Jani Nikula j...@nikula.org writes: + status = notmuch_message_tags_to_maildir_flags (message); ... + /* + * Note: Unfortunately a failed maildir flag sync might + * already have renamed the file, in which case the cleanup + * path will fail. + */ I'd like to

[PATCH 09/11] cli/insert: add fail path to add_file_to_database

2014-09-22 Thread Jani Nikula
Handle failures gracefully in add_file_to_database, renamed simply add_file while at it. Add keep option to not remove the message from database if tagging or tag syncing to maildir flags fails. Expand the function documentation to cover the changes. --- notmuch-insert.c | 89

[PATCH 09/11] cli/insert: add fail path to add_file_to_database

2014-09-22 Thread Jani Nikula
Handle failures gracefully in add_file_to_database, renamed simply add_file while at it. Add keep option to not remove the message from database if tagging or tag syncing to maildir flags fails. Expand the function documentation to cover the changes. --- notmuch-insert.c | 89