[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 7:54 am: > On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements > wrote: > > Yikes. I don't envy you this patch. Two minor nits, otherwise this > > and the next patch LGTM. > > Thanks for the review. I'll roll another version, I think it will be > better with

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-06 Thread Jani Nikula
On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements wrote: > Yikes. I don't envy you this patch. Two minor nits, otherwise this > and the next patch LGTM. Thanks for the review. I'll roll another version, I think it will be better with your suggestions incorporated. > Quoth Jani Nikula on Feb

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-06 Thread Austin Clements
Quoth Jani Nikula on Feb 06 at 7:54 am: On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements amdra...@mit.edu wrote: Yikes. I don't envy you this patch. Two minor nits, otherwise this and the next patch LGTM. Thanks for the review. I'll roll another version, I think it will be better

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-05 Thread Austin Clements
Yikes. I don't envy you this patch. Two minor nits, otherwise this and the next patch LGTM. Quoth Jani Nikula on Feb 04 at 12:41 am: > Use the new notmuch argument parser to handle arguments in "notmuch > show". There are two corner case functional changes: > > 1) Also set params.raw = 1 when

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-05 Thread Austin Clements
Yikes. I don't envy you this patch. Two minor nits, otherwise this and the next patch LGTM. Quoth Jani Nikula on Feb 04 at 12:41 am: Use the new notmuch argument parser to handle arguments in notmuch show. There are two corner case functional changes: 1) Also set params.raw = 1 when

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-05 Thread Jani Nikula
On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements amdra...@mit.edu wrote: Yikes. I don't envy you this patch. Two minor nits, otherwise this and the next patch LGTM. Thanks for the review. I'll roll another version, I think it will be better with your suggestions incorporated. Quoth Jani

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-04 Thread Jani Nikula
On Sat, 04 Feb 2012 00:00:00 +, Mark Walters wrote: > > On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula wrote: > > Use the new notmuch argument parser to handle arguments in "notmuch > > show". There are two corner case functional changes: > > > > 1) Also set params.raw = 1 when

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-04 Thread Jani Nikula
Use the new notmuch argument parser to handle arguments in "notmuch show". There are two corner case functional changes: 1) Also set params.raw = 1 when defaulting to raw format when part is requested but format is not specified. 2) Do not set params.decrypt if crypto context creation fails.

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

2012-02-04 Thread Mark Walters
On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula wrote: > Use the new notmuch argument parser to handle arguments in "notmuch > show". There are two corner case functional changes: > > 1) Also set params.raw = 1 when defaulting to raw format when part is >requested but format is not

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-04 Thread Jani Nikula
On Sat, 04 Feb 2012 00:00:00 +, Mark Walters markwalters1...@gmail.com wrote: On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula j...@nikula.org wrote: Use the new notmuch argument parser to handle arguments in notmuch show. There are two corner case functional changes: 1) Also set

[PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-03 Thread Jani Nikula
Use the new notmuch argument parser to handle arguments in notmuch show. There are two corner case functional changes: 1) Also set params.raw = 1 when defaulting to raw format when part is requested but format is not specified. 2) Do not set params.decrypt if crypto context creation fails.

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

2012-02-03 Thread Mark Walters
On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula j...@nikula.org wrote: Use the new notmuch argument parser to handle arguments in notmuch show. There are two corner case functional changes: 1) Also set params.raw = 1 when defaulting to raw format when part is requested but format is not