[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-12-07 Thread David Bremner
On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin wrote: > Add optional props argument to `notmuch-show-get-header'. Use it to > get headers in `notmuch-show-insert-part-multipart/signed' and > `notmuch-show-insert-part-multipart/encrypted'. Pushed this series. d

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-12-07 Thread Dmitry Kurochkin
David, this seems ready for push as well. Regards, Dmitry

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-12-07 Thread Dmitry Kurochkin
David, this seems ready for push as well. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-12-07 Thread David Bremner
On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Add optional props argument to `notmuch-show-get-header'. Use it to get headers in `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted'. Pushed this series. d

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-29 Thread Jameson Graef Rollins
On Mon, 28 Nov 2011 13:28:55 -0500, Austin Clements amdra...@mit.edu wrote: If props isn't provided, it'll be nil, so notmuch-show-get-prop will also interpret its optional props argument as not being provided. On Mon, 28 Nov 2011 22:11:43 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-29 Thread Dmitry Kurochkin
Hi Jamie. On Mon, 28 Nov 2011 06:24:19 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: -(defun notmuch-show-get-header (header) +(defun notmuch-show-get-header (header optional props)

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-28 Thread Dmitry Kurochkin
Hi Jamie. On Mon, 28 Nov 2011 06:24:19 -0800, Jameson Graef Rollins wrote: > On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin gmail.com> wrote: > > -(defun notmuch-show-get-header (header) > > +(defun notmuch-show-get-header (header props) > >"Return the named header of the current

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-28 Thread Austin Clements
Quoth Jameson Graef Rollins on Nov 28 at 6:24 am: > On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin gmail.com> wrote: > > -(defun notmuch-show-get-header (header) > > +(defun notmuch-show-get-header (header props) > >"Return the named header of the current message, if any." > > -

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-28 Thread Jameson Graef Rollins
On Mon, 28 Nov 2011 13:28:55 -0500, Austin Clements wrote: > If props isn't provided, it'll be nil, so notmuch-show-get-prop will > also interpret its optional props argument as not being provided. On Mon, 28 Nov 2011 22:11:43 +0400, Dmitry Kurochkin wrote: > If props is not supplied it is

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-28 Thread Jameson Graef Rollins
On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin wrote: > -(defun notmuch-show-get-header (header) > +(defun notmuch-show-get-header (header props) >"Return the named header of the current message, if any." > - (plist-get (notmuch-show-get-prop :headers) header)) > + (plist-get

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-28 Thread Jameson Graef Rollins
On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: -(defun notmuch-show-get-header (header) +(defun notmuch-show-get-header (header optional props) Return the named header of the current message, if any. - (plist-get (notmuch-show-get-prop :headers)

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-27 Thread Austin Clements
Both patches look good to me. (I don't think the compiler could warn about the unused `headers' binding even if it wanted to because of dynamic scoping.)

Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-27 Thread Austin Clements
Both patches look good to me. (I don't think the compiler could warn about the unused `headers' binding even if it wanted to because of dynamic scoping.) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-26 Thread Dmitry Kurochkin
Add optional props argument to `notmuch-show-get-header'. Use it to get headers in `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted'. --- emacs/notmuch-show.el | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 1/2] emacs: remove some code duplication in notmuch-show

2011-11-25 Thread Dmitry Kurochkin
Add optional props argument to `notmuch-show-get-header'. Use it to get headers in `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted'. --- emacs/notmuch-show.el | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git